Added dprint config and commit-on-master task#66235
Added dprint config and commit-on-master task#66235jakebailey merged 63 commits intoDefinitelyTyped:masterfrom
Conversation
|
Just as a meta-note about the workflows, I'd prefer if job configs were to come last; they get long and having them at the top will push info like the name/triggers/etc down to the bottom when it's usually important info. I don't think I've seen jobs stuck at the top before. |
|
@jakebailey, @sandersn, @andrewbranch, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@sandersn, @jakebailey, @andrewbranch, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
#66235 (comment) shows the new dangerbot output. |
|
Okay, this PR should be ready to go, whenever we're ready to flip the switch! It'll immediately format about 141 files. |
typescript-bot
added
Maintainer Approved
Self Merge
|
@jakebailey, @sandersn, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
Ready to merge |
|
|
7 participants
Corresponds to the changes described in #65993. This initial PR adds:
.github/workflows/format-and-commit.yml: adds a workflow to run dprint and commit changesmasteris commented out.vscode/extensions.json: recommends the dprint extension.vscode/settings.template.json: sets VS Code to format with the dprint extension by defaultdprint.json: configuration file for dprint, including"excludes"for (known or seemingly) auto-generated packagesREADME.mddocs around formattingpackage.json: a new dev dependency ondprintBecauseformat-and-commit.yml's commit trigger is commented out, merging this PR won't causedprintto be applied to all files.Co-authored-by: @jakebailey