[react] react@next is now react@canary #65734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. react-dom (unpkg)was missing the following properties:
react-is (unpkg)was missing the following properties:
react (unpkg)was missing the following properties:
|
Contributor
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 3 packages in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. InactiveThis PR has been inactive for 6 days. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 65734,
"author": "eps1lon",
"headCommitOid": "21cb4ea18ef448705fe53ae0dee994fafda6c854",
"mergeBaseOid": "a578a934d741796e02f961f6303dec3dc9b6e2a5",
"lastPushDate": "2023-06-10T09:15:46.000Z",
"lastActivityDate": "2023-06-19T12:22:45.000Z",
"mergeOfferDate": "2023-06-12T17:51:25.000Z",
"mergeRequestDate": "2023-06-19T12:22:45.000Z",
"mergeRequestUser": "eps1lon",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react-dom",
"kind": "edit",
"files": [
{
"path": "types/react-dom/canary.d.ts",
"kind": "definition"
},
{
"path": "types/react-dom/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react-dom/package.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-packagejson) and not moving towards it (check: `exports`)"
},
{
"path": "types/react-dom/test/canary-tests.tsx",
"kind": "test"
},
{
"path": "types/react-dom/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"MartynasZilinskas",
"theruther4d",
"Jessidhia",
"eps1lon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "react-is",
"kind": "edit",
"files": [
{
"path": "types/react-is/canary.d.ts",
"kind": "definition"
},
{
"path": "types/react-is/test/canary-tests.tsx",
"kind": "test"
},
{
"path": "types/react-is/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"AviVahl",
"christianchown",
"eps1lon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/OTHER_FILES.txt",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-other_filestxt) and not moving towards it"
},
{
"path": "types/react/canary.d.ts",
"kind": "definition"
},
{
"path": "types/react/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react/package.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-packagejson) and not moving towards it (check: `exports`)"
},
{
"path": "types/react/test/canary.tsx",
"kind": "test"
},
{
"path": "types/react/ts5.0/OTHER_FILES.txt",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-other_filestxt) and not moving towards it"
},
{
"path": "types/react/ts5.0/canary.d.ts",
"kind": "definition"
},
{
"path": "types/react/ts5.0/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react/ts5.0/test/canary.tsx",
"kind": "test"
},
{
"path": "types/react/ts5.0/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/react/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan",
"priyanshurav",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sheetalkamat",
"date": "2023-06-12T17:50:31.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1585577627,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Author is Owner
Contributor
|
🔔 @MartynasZilinskas @theruther4d @Jessidhia @AviVahl @christianchown @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
eps1lon
force-pushed
the
feat/react/canary
branch
from
76759dd to
21cb4ea
Compare
sheetalkamat
approved these changes
Jun 12, 2023
typescript-bot
added
Maintainer Approved
Self Merge
Contributor
Collaborator
Author
|
Ready to merge |
Desplandis
pushed a commit
to Desplandis/DefinitelyTyped
that referenced
this pull request
Jul 3, 2023
…ry by @eps1lon * [react] react@next is now react@canary * Same for react-dom * Same for react-is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR:
react@nextis nowreact@canaryand we reflect that now types.To get types for
react@canaryuseor
See https://react.dev/blog/2023/05/03/react-canaries