chore: added jsdoc/check-tag-names to ESLint config #65660
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| module.exports = { | ||
| root: true, | ||
| parser: '@typescript-eslint/parser', | ||
| parserOptions: { | ||
| project: true, | ||
| warnOnUnsupportedTypeScriptVersion: false, | ||
| }, | ||
| plugins: ['@typescript-eslint', 'jsdoc'], | ||
| rules: { | ||
| 'dt-header': 'error', | ||
| 'export-just-namespace': 'error', | ||
| 'jsdoc/check-tag-names': [ | ||
| 'error', | ||
| { | ||
| // TODO: Some (but not all) of these tags should likely be removed from this list. | ||
| // Additionally, some may need to be contributed to eslint-plugin-jsdoc. | ||
| definedTags: [ | ||
| 'addVersion', | ||
| 'api', | ||
| 'author', | ||
| 'beta', | ||
| 'brief', | ||
| 'category', | ||
| 'cfg', | ||
| 'chainable', | ||
| 'check', | ||
| 'classDescription', | ||
| 'condparamprivilege', | ||
| 'constraint', | ||
| 'credits', | ||
| 'declaration', | ||
| 'defApiFeature', | ||
| 'defaultValue', | ||
| 'detail', | ||
| 'end', | ||
| 'eventproperty', | ||
| 'experimental', | ||
| 'export', | ||
| 'expose', | ||
| 'extendscript', | ||
| 'factory', | ||
| 'field', | ||
| 'final', | ||
| 'fixme', | ||
| 'fluent', | ||
| 'for', | ||
| 'governance', | ||
| 'header', | ||
| 'hidden-property', | ||
| 'hidden', | ||
| 'id', | ||
| 'jsx', | ||
| 'label', | ||
| 'language', | ||
| 'legacy', | ||
| 'link', | ||
| 'listen', | ||
| 'locus', | ||
| 'methodOf', | ||
| 'minVersion', | ||
| 'ngdoc', | ||
| 'nonstandard', | ||
| 'note', | ||
| 'npm', | ||
| 'observable', | ||
| 'option', | ||
| 'optionobject', | ||
| 'options', | ||
| 'packageDocumentation', | ||
| 'param', | ||
| 'parent', | ||
| 'platform', | ||
| 'plugin', | ||
| 'preserve', | ||
| 'privateRemarks', | ||
| 'privilegeLevel', | ||
| 'privilegeName', | ||
| 'proposed', | ||
| 'range', | ||
| 'readOnly', | ||
| 'related', | ||
| 'remark', | ||
| 'remarks', | ||
| 'required', | ||
| 'requires', | ||
| 'restriction', | ||
| 'returnType', | ||
| 'section', | ||
| 'see', | ||
| 'since', | ||
| 'const', | ||
| 'singleton', | ||
| 'source', | ||
| 'struct', | ||
| 'suppress', | ||
| 'targetfolder', | ||
| 'enum', | ||
| 'title', | ||
| 'record', | ||
| 'title', | ||
| 'TODO', | ||
| 'trigger', | ||
| 'triggers', | ||
| 'typeparam', | ||
| 'typeParam', | ||
| 'unsupported', | ||
| 'url', | ||
| 'usage', | ||
| 'warn', | ||
| 'warning', | ||
| 'version', | ||
| ], | ||
| typed: true, | ||
| }, | ||
| ], | ||
| 'no-any-union': 'error', | ||
| 'no-bad-reference': 'error', | ||
| 'no-const-enum': 'error', | ||
| 'no-dead-reference': 'error', | ||
| 'no-declare-current-package': 'error', | ||
| 'no-import-default-of-export-equals': 'error', | ||
| 'no-outside-dependencies': 'error', | ||
| 'no-self-import': 'error', | ||
| 'no-single-element-tuple-type': 'error', | ||
| 'no-unnecessary-generics': 'error', | ||
| 'no-useless-files': 'error', | ||
| 'prefer-declare-function': 'error', | ||
| 'redundant-undefined': 'error', | ||
| 'trim-file': 'error', | ||
| }, | ||
| settings: { | ||
| jsdoc: { | ||
| tagNamePreference: { | ||
| argument: 'argument', | ||
| exception: 'exception', | ||
| function: 'function', | ||
| method: 'method', | ||
| param: 'param', | ||
| return: 'return', | ||
| returns: 'returns', | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| { "extends": "@definitelytyped/dtslint/dt.json" } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ const { | |
| const assert: typeof Ember.assert = Ember.assert; | ||
|
|
||
| /** | ||
| * `@ember/debug` tests | ||
|
Collaborator
Author
There was a problem hiding this comment. Pending gajus/eslint-plugin-jsdoc#1116, this seemed like the most straightforward resolution. |
||
| */ | ||
| // @ts-expect-error | ||
| runInDebug(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ import { | |
| } from '@ember/debug'; | ||
|
|
||
| /** | ||
| * `@ember/debug` tests | ||
| */ | ||
| // @ts-expect-error | ||
| runInDebug(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ import { | |
| } from '@ember/debug'; | ||
|
|
||
| /** | ||
| * `@ember/debug` tests | ||
| */ | ||
| // @ts-expect-error | ||
| runInDebug(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,9 +3,6 @@ import usage = require('gulp-help-doc'); | |
|
|
||
| /** | ||
| * Demo task | ||
| */ | ||
| gulp.task('demo', function() {}); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a list of tags that are used on DT and explicitly allowed, or is it the opposite: tags that are explicitly disallowed (and used to be on DT)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the tags that are used on DT and explicitly allowed. https://github.com/gajus/eslint-plugin-jsdoc/blob/main/docs/rules/check-tag-names.md#definedtags