Remove types for @wordpress/data-controls #65111
Conversation
|
@noahtallen Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 1 package in this PR (and infra files)
Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 65111,
"author": "noahtallen",
"headCommitOid": "d10d73d90f2a3b67f86879c6d3721c26d40632d0",
"mergeBaseOid": "4e2081efcd3b2ddfc351c07391390847669e6b90",
"lastPushDate": "2023-04-13T21:34:24.000Z",
"lastActivityDate": "2023-04-14T21:10:33.000Z",
"mergeOfferDate": "2023-04-14T19:14:34.000Z",
"mergeRequestDate": "2023-04-14T21:10:33.000Z",
"mergeRequestUser": "noahtallen",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "wordpress__data-controls",
"kind": "delete",
"files": [
{
"path": "types/wordpress__data-controls/index.d.ts",
"kind": "definition"
},
{
"path": "types/wordpress__data-controls/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/wordpress__data-controls/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/wordpress__data-controls/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/wordpress__data-controls/wordpress__data-controls-tests.ts",
"kind": "test"
}
],
"owners": [
"dsifford"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2023-04-14T19:13:50.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "dsifford",
"date": "2023-04-14T13:02:55.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1507614086,
"ciResult": "pass"
} |
|
🔔 @dsifford — please review this PR in the next few days. Be sure to explicitly select |
|
@noahtallen The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
typescript-bot
added
the
Owner Approved
typescript-bot
added
Maintainer Approved
Self Merge
|
@noahtallen: Everything looks good here. I am ready to merge this PR (at d10d73d) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@dsifford: you can do this too.) |
|
Ready to merge |
4 participants
Removes the types for wordpress__data-controls, since we've just published them to npm (sse WordPress/gutenberg#49647)
Please fill in this template.
npm test <package to test>.If removing a declaration:
notNeededPackages.json.