Skip to content

Fix codemirror types for TS 5.0 beta #64011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 5 commits into from
Jan 23, 2023
Merged

Fix codemirror types for TS 5.0 beta #64011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91bd989
Fix codemirror types for TS 5.0 beta
sandersn Jan 21, 2023
cacbb7f
also update minimum required TS version
sandersn Jan 21, 2023
0db82c2
Merge branch 'master' into fix-codemirror-for-TS5.0
sandersn Jan 23, 2023
9c48460
Update react-codemirror minimum TS version
sandersn Jan 23, 2023
f6487d7
Fix formatting lint
sandersn Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions types/codemirror/codemirror-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,13 @@ const a = CodeMirror.findModeByMIME('foo');
const b = CodeMirror.findModeByExtension('foo');
const c = CodeMirror.findModeByFileName('foo');
const d = CodeMirror.findModeByName('foo');
declare var editor: CodeMirror.Editor;
editor.on('cut', (instance, event) => {
event.clipboardData;
});
editor.on('copy', (instance, event) => {
event.clipboardData;
});
editor.on('paste', (instance, event) => {
event.clipboardData;
});
10 changes: 1 addition & 9 deletions types/codemirror/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// koddsson <https://github.com/koddsson>
// ficristo <https://github.com/ficristo>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// TypeScript Version: 3.8
// TypeScript Version: 5.0

export = CodeMirror;
export as namespace CodeMirror;
Expand Down Expand Up @@ -550,20 +550,12 @@ declare namespace CodeMirror {
eventName: K,
handler: (instance: Editor, event: GlobalEventHandlersEventMap[K]) => void,
): void;
on<K extends DOMEvent & keyof DocumentAndElementEventHandlersEventMap>(
eventName: K,
handler: (instance: Editor, event: DocumentAndElementEventHandlersEventMap[K]) => void,
): void;

off<T extends keyof EditorEventMap>(eventName: T, handler: EditorEventMap[T]): void;
off<K extends DOMEvent & keyof GlobalEventHandlersEventMap>(
eventName: K,
handler: (instance: Editor, event: GlobalEventHandlersEventMap[K]) => void,
): void;
off<K extends DOMEvent & keyof DocumentAndElementEventHandlersEventMap>(
eventName: K,
handler: (instance: Editor, event: DocumentAndElementEventHandlersEventMap[K]) => void,
): void;

/** Expose the state object, so that the Editor.state.completionActive property is reachable */
state: any;
Expand Down
2 changes: 1 addition & 1 deletion types/react-codemirror/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// Definitions by: Vicky Lai <https://github.com/velveret>
// Rudi Chen <https://github.com/rudi-c>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// TypeScript Version: 3.8
// TypeScript Version: 5.0

/// <reference types="react"/>
/// <reference types="codemirror"/>
Expand Down