node/os: Make scopeid of type undefined in NetworkInterfaceInfoIPv4 by phm07 · Pull Request #62389 · DefinitelyTyped/DefinitelyTyped

phm07 · 2022-09-23T19:53:18Z

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run npm test <package to test>.

If changing an existing definition:

Provide a URL to documentation or source code which provides context for the suggested changes: https://nodejs.org/api/os.html#osnetworkinterfaces
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

When NetworkInterfaceInfoIPv4 doesn't include scopeid: undefined, scopeid will not exist on union type NetworkInterfaceInfo. See this GitHub issue.

typescript-bot · 2022-09-23T19:54:00Z

@pauhull Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

node — on npm, on unpkg
- owner-approval: @peterblazejewicz

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 62389,
  "author": "pauhull",
  "headCommitOid": "79ca3057cbe5fec90e523babd9c99775b2b49f46",
  "mergeBaseOid": "0c0777bd1dd9b34f4fa4e36aecfdc3228e64d454",
  "lastPushDate": "2022-09-25T19:54:19.000Z",
  "lastActivityDate": "2022-09-26T19:05:38.000Z",
  "mergeOfferDate": "2022-09-26T18:32:36.000Z",
  "mergeRequestDate": "2022-09-26T19:05:38.000Z",
  "mergeRequestUser": "pauhull",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/os.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/ts4.8/os.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v14/os.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v14/ts4.8/os.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/ts4.8/os.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-09-26T18:31:52.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1256616071,
  "ciResult": "pass"
}

typescript-bot · 2022-09-23T19:54:03Z

Hey @pauhull,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

typescript-bot · 2022-09-23T19:54:04Z

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot · 2022-09-23T20:30:30Z

@pauhull The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

peterblazejewicz · 2022-09-25T17:46:10Z

@pauhull please update from master, that would fix IC errors

Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <[email protected]>

typescript-bot · 2022-09-25T20:30:12Z

@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

peterblazejewicz

LGTM!
@pauhull thanks!

typescript-bot · 2022-09-26T18:32:36Z

@pauhull: Everything looks good here. I am ready to merge this PR (at 79ca305) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina: you can do this too.)

phm07 · 2022-09-26T19:05:38Z

Ready to merge

node/os: Make scopeid of type undefined in NetworkInterfaceInfoIPv4

0832c2b

phm07 requested review from eps1lon and peterblazejewicz as code owners September 23, 2022 19:53

typescript-bot added Critical package Untested Change This PR does not touch tests labels Sep 23, 2022

typescript-bot added the The CI failed When GH Actions fails label Sep 23, 2022

phm07 mentioned this pull request Sep 24, 2022

Update node types for TS 4.9 beta #62375

Merged