Conversation
Add static method AbortSignal.timeout.
If this works, a later version of TS can re-add AbortSignal.abort and
node can add support for that too.
I created a ts4.8/ subdirectory for each of v14, v16, and current. I
didn't try to share types like before. With 2*3 entries I think it's
reasonably maintainable and the old way was very confusing to change.
typesVersions has a weird entry `">4.9.0-a": { "*": ["*"] }` which
works around a bug in semver parsing in Typescript. I need to ship a new
version of dtslint to allow this but I wanted to get this PR out for
people to look at.
sandersn
changed the title
Member
|
The semver bug is over at microsoft/TypeScript#50909 FWIW |
Collaborator
|
The minimum prerelease version is |
rbuckton
requested changes
Sep 23, 2022
Comment on lines
+5
to
+6
| ">4.9.0-a": { "*": ["*"] }, | ||
| "<=4.8": { "*": ["ts4.8/*"] } |
Collaborator
There was a problem hiding this comment.
Suggested change
| ">4.9.0-a": { "*": ["*"] }, | |
| "<=4.8": { "*": ["ts4.8/*"] } | |
| ">=4.9.0-0": { "*": ["*"] }, | |
| "<4.9.0-0": { "*": ["ts4.8/*"] } |
Contributor
Author
There was a problem hiding this comment.
Actually, with "<4.9.0-0", ">=4.9.0-0" is no longer needed. I'll change dtslint to allow <=4.8 or <4.9.0-0
Contributor
Author
|
I'm going to update the format of typesVersions in dependents in a separate PR. Those are the only failures, so I'm going to merge this. |
Member
|
would that impact CI validation time? Let me check |
Contributor
|
#62389 fails because of this |
Member
|
@pauhull those errors with TS versioning have been fixed in master. You have to update your PR from current master |
This was referenced Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add static method AbortSignal.timeout.
If this works, a later version of TS can re-add AbortSignal.abort and node can add support for that too.
I created a ts4.8/ subdirectory for each of v14, v16, and current. I didn't try to share types like before. With 2*3 entries I think it's reasonably maintainable and the old way was very confusing to change.
typesVersions has a weird entry
">4.9.0-a": { "*": ["*"] }which works around a bug in semver parsing in Typescript. I need to ship a new version of dtslint to allow this but I wanted to get this PR out for people to look at.