Skip to content

[frappe-gantt] Upgrade version to 0.6#62347

Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
engunai:master
Sep 22, 2022
Merged

[frappe-gantt] Upgrade version to 0.6#62347
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
engunai:master

Conversation

@engunai
Copy link
Copy Markdown
Contributor

@engunai engunai commented Sep 21, 2022 •
edited
Loading

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@engunai
Upgrade version to 0.6
9677674 
* added global variable VIEW_ MODE

* the attribute viewMode adds the option Year
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Sep 21, 2022 •
edited
Loading

@zhengruncai Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 62347,
  "author": "zhengruncai",
  "headCommitOid": "b98cb6787fdfe5a5ac8b7b01585766aa7af117e2",
  "mergeBaseOid": "68c4992778646e47f95973f5f4a65834aa632483",
  "lastPushDate": "2022-09-21T07:38:14.000Z",
  "lastActivityDate": "2022-09-22T02:20:49.000Z",
  "mergeOfferDate": "2022-09-21T09:48:49.000Z",
  "mergeRequestDate": "2022-09-22T02:20:49.000Z",
  "mergeRequestUser": "zhengruncai",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "frappe-gantt",
      "kind": "edit",
      "files": [
        {
          "path": "types/frappe-gantt/frappe-gantt-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/frappe-gantt/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "samalexander",
        "eli7vh"
      ],
      "addedOwners": [
        "zhengruncai"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "samalexander",
      "date": "2022-09-21T09:48:01.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1253312619,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Edits Owners This PR adds or removes owners label Sep 21, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Sep 21, 2022

🔔 @samalexander @ELI7VH — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Sep 21, 2022 •
edited
Loading

@zhengruncai Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 62347,
  "author": "zhengruncai",
  "headCommitOid": "b98cb6787fdfe5a5ac8b7b01585766aa7af117e2",
  "mergeBaseOid": "68c4992778646e47f95973f5f4a65834aa632483",
  "lastPushDate": "2022-09-21T07:38:14.000Z",
  "lastActivityDate": "2022-09-22T02:20:49.000Z",
  "mergeOfferDate": "2022-09-21T09:48:49.000Z",
  "mergeRequestDate": "2022-09-22T02:20:49.000Z",
  "mergeRequestUser": "zhengruncai",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "frappe-gantt",
      "kind": "edit",
      "files": [
        {
          "path": "types/frappe-gantt/frappe-gantt-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/frappe-gantt/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "samalexander",
        "eli7vh"
      ],
      "addedOwners": [
        "zhengruncai"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "samalexander",
      "date": "2022-09-21T09:48:01.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1253312619,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Sep 21, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Sep 21, 2022

@zhengruncai The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@engunai
Upgrade version to 0.6
b98cb67 
* added global variable VIEW_ MODE

* the attribute viewMode adds the option Year
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Sep 21, 2022
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Sep 21, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Sep 21, 2022

@zhengruncai: Everything looks good here. I am ready to merge this PR (at b98cb67) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@samalexander, @ELI7VH: you can do this too.)

@engunai
Copy link
Copy Markdown
Contributor Author

engunai commented Sep 22, 2022

Ready to merge

@typescript-bot typescript-bot merged commit 35b81ce into DefinitelyTyped:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@samalexander samalexander samalexander approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Edits Owners This PR adds or removes owners Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@engunai @typescript-bot @samalexander