Remove ts4.0 versions #62240
Merged
Remove ts4.0 versions #62240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TS 4.0 is not supported on DT anymore.
Contributor
|
@sandersn Thank you for submitting this PR! This is a live comment which I will keep updated. 4 packages in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 62240,
"author": "sandersn",
"headCommitOid": "9be1688bf644c07454345aecd45dc9049fd63d21",
"mergeBaseOid": "ba8b4c8005d100eea96f5da4852612530d30abd0",
"lastPushDate": "2022-09-13T16:40:07.000Z",
"lastActivityDate": "2022-09-13T17:08:15.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "express-serve-static-core",
"kind": "edit",
"files": [
{
"path": "types/express-serve-static-core/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/express-serve-static-core/ts4.0/express-serve-static-core-tests.ts",
"kind": "test"
},
{
"path": "types/express-serve-static-core/ts4.0/index.d.ts",
"kind": "definition"
},
{
"path": "types/express-serve-static-core/ts4.0/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/express-serve-static-core/ts4.0/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"borisyankov",
"micksatana",
"samijaber",
"JoseLion",
"dwrss",
"andoshin11"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "express",
"kind": "edit",
"files": [
{
"path": "types/express/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/express/ts4.0/express-tests.ts",
"kind": "test"
},
{
"path": "types/express/ts4.0/index.d.ts",
"kind": "definition"
},
{
"path": "types/express/ts4.0/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/express/ts4.0/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"borisyankov",
"CMUH",
"puneetar",
"dfrankland"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "react-router",
"kind": "edit",
"files": [
{
"path": "types/react-router/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/react-router/ts4.0/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-router/ts4.0/test/Children.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/InheritingRoute.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/MemoryRouter.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/NavigateWithContext.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/Prompt.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/RouterContext.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/Switch.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/WithRouter.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/Ambiguous.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/Animation.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/Auth.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/Basic.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/CustomLink.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/ModalGallery.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/NoMatch.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/Params.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/PreventingTransitions.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/README.md",
"kind": "markdown"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/Recursive.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/RouteConfig.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/Sidebar.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/examples-from-react-router-website/StaticRouter.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/test/hooks.tsx",
"kind": "test"
},
{
"path": "types/react-router/ts4.0/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/react-router/ts4.0/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"sergey-buturlakin",
"mrk21",
"vasek17",
"ngbrown",
"awendland",
"KostyaEsmukov",
"johnnyreilly",
"LKay",
"DovydasNavickas",
"huy-nguyen",
"grmiade",
"DaIgeb",
"egorshulga",
"rraina",
"t49tran",
"8enSmith",
"wezleytsai",
"eps1lon",
"HipsterBrown",
"pawfa"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "ya-disk",
"kind": "edit",
"files": [
{
"path": "types/ya-disk/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/ya-disk/ts4.0/index.d.ts",
"kind": "definition"
},
{
"path": "types/ya-disk/ts4.0/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/ya-disk/ts4.0/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/ya-disk/ts4.0/ya-disk-tests.ts",
"kind": "test"
}
],
"owners": [
"vladislav805"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 1245665812,
"ciResult": "pass"
} |
Contributor
|
🔔 @borisyankov @micksatana @samijaber @JoseLion @dwrss @andoshin11 @CMUH @puneetar @dfrankland @sergey-buturlakin @mrk21 @vasek17 @ngbrown @awendland @KostyaEsmukov @johnnyreilly @LKay @DovydasNavickas @huy-nguyen @Grmiade @DaIgeb @egorshulga @rraina @t49tran @8enSmith @wezleytsai @eps1lon @HipsterBrown @pawfa @vladislav805 — please review this PR in the next few days. Be sure to explicitly select |
Contributor
Author
|
Not sure why express-pino-logger didn't successfully |
lobsterkatie
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Sep 17, 2022
Recently, the issue described in DefinitelyTyped/DefinitelyTyped#40138 (wherein the `Request` and `Response` types from express claim never to have heard of standard properties like `headers`) flared up in our remix tests. It turns out the culprit was that a few days ago, DefinitelyTyped removed TS 4.0 support from a number of packages[1], among them `@types/express-serve-static-core` (upon which `@types/express` depends). Key changes in this fix: - Lock `@types/express-serve-static-core` to the last version before this change. - Add `@types/express` to `@sentry/remix`'s dev dependencies (where it should have been all along). - Update all usages of `@types/express` to latest. (Not strictly necessary, but done as part of my debugging. Doesn't seem to break anything, and we might as well be up to date.) [1] DefinitelyTyped/DefinitelyTyped#62240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TS 4.0 is not supported on DT anymore.