[source-map-support] Improve types#61841
[source-map-support] Improve types#61841typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@BendingBender Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
@BendingBender: I see that you have added yourself as an owner, are you sure you want to become an owner? Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 61841,
"author": "BendingBender",
"headCommitOid": "992d3b7dfa4bd9764f8a21c767409f418bf6c4e8",
"mergeBaseOid": "0a4b8f5421264610c1c5dde5cde9cbb1fbd21b3e",
"lastPushDate": "2022-08-21T09:47:11.000Z",
"lastActivityDate": "2022-08-24T08:26:25.000Z",
"mergeOfferDate": "2022-08-24T08:20:35.000Z",
"mergeRequestDate": "2022-08-24T08:26:25.000Z",
"mergeRequestUser": "BendingBender",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "source-map-support",
"kind": "edit",
"files": [
{
"path": "types/source-map-support/index.d.ts",
"kind": "definition"
},
{
"path": "types/source-map-support/source-map-support-tests.ts",
"kind": "test"
}
],
"owners": [
"Bartvds",
"jason0x43",
"natealcedo",
"tough-griff"
],
"addedOwners": [
"BendingBender"
],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "johnnyreilly",
"date": "2022-08-24T08:19:51.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1221510600,
"ciResult": "pass"
} |
typescript-bot
added
the
Popular package
|
🔔 @Bartvds @jason0x43 @natealcedo @tough-griff — please review this PR in the next few days. Be sure to explicitly select |
- add `state` parameter to `wrapCallSite` - add `CallSite` definition - allow `url` in `UrlAndMap` to be optional - add missing doc comments - improve tests
BendingBender
force-pushed
the
source-map-support
branch
from
850fe30 to
992d3b7
Compare
typescript-bot
added
Maintainer Approved
Self Merge
|
@BendingBender: Everything looks good here. I am ready to merge this PR (at 992d3b7) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@Bartvds, @jason0x43, @natealcedo, @tough-griff: you can do this too.) |
|
Ready to merge |
…@BendingBender - add `state` parameter to `wrapCallSite` - add `CallSite` definition - allow `url` in `UrlAndMap` to be optional - add missing doc comments - improve tests
3 participants
stateparameter towrapCallSiteCallSitedefinitionurlinUrlAndMapto be optionalPlease fill in this template.
npm test <package to test>.If changing an existing definition: