Add type for srtparsejs#61155
Merged
sheetalkamat merged 1 commit intoDefinitelyTyped:masterfrom Jul 8, 2022
Qiming-Liu:srtparsejs
Merged
Add type for srtparsejs#61155sheetalkamat merged 1 commit intoDefinitelyTyped:masterfrom Qiming-Liu:srtparsejs
sheetalkamat merged 1 commit intoDefinitelyTyped:masterfrom
Qiming-Liu:srtparsejs
Conversation
Contributor
|
@Qiming-Liu Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 61155,
"author": "Qiming-Liu",
"headCommitOid": "e0dd7e18d1e93cb8774dbce500e59a2c3b5c0a6d",
"mergeBaseOid": "469914ea239cca1d50f1343610d48cbca21c1dde",
"lastPushDate": "2022-07-08T20:19:29.000Z",
"lastActivityDate": "2022-07-08T20:22:21.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "srtparsejs",
"kind": "add",
"files": [
{
"path": "types/srtparsejs/index.d.ts",
"kind": "definition"
},
{
"path": "types/srtparsejs/srtparsejs-tests.ts",
"kind": "test"
},
{
"path": "types/srtparsejs/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/srtparsejs/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"Qiming-Liu"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 1179334139,
"ciResult": "pass"
} |
Contributor
|
🔔 @Qiming-Liu — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm test <package to test>.If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.