Repository navigation
[@type/node] options.filter of fs.cp() can return a Promise - #61042
Conversation
|
@FuuuOverclocking Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 61042,
"author": "FuuuOverclocking",
"headCommitOid": "93903f7c1180c83eafc3547f56e77201dd1d5359",
"mergeBaseOid": "9b4c4f691ac0cf6dac65d6be2067bf0523e6180b",
"lastPushDate": "2022-07-27T06:27:35.000Z",
"lastActivityDate": "2022-07-28T02:28:15.000Z",
"mergeOfferDate": "2022-07-27T18:03:27.000Z",
"mergeRequestDate": "2022-07-28T02:28:15.000Z",
"mergeRequestUser": "FuuuOverclocking",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/fs.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/fs.ts",
"kind": "test"
},
{
"path": "types/node/v16/fs.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/test/fs.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"SimonSchick",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gabritto",
"date": "2022-07-27T18:02:44.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "mcollina",
"date": "2022-07-27T08:58:51.000Z",
"isMaintainer": false
},
{
"type": "stale",
"reviewer": "peterblazejewicz",
"date": "2022-07-19T18:48:47.000Z",
"abbrOid": "0c8b400"
},
{
"type": "stale",
"reviewer": "yoursunny",
"date": "2022-07-01T13:37:08.000Z",
"abbrOid": "89db37b"
}
],
"mainBotCommentID": 1171903578,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Untested Change
|
🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina — please review this PR in the next few days. Be sure to explicitly select |
|
@FuuuOverclocking The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
typescript-bot
removed
The CI failed
typescript-bot
added
the
Owner Approved
| * @default false | ||
| */ | ||
| recursive?: boolean; | ||
| } |
There was a problem hiding this comment.
Missing verbatimSymlinks.
| */ | ||
| recursive?: boolean; | ||
| } | ||
| export interface CopySyncOptions { |
There was a problem hiding this comment.
Maybe extract the common options to CopyOptionsCommon to reduce duplication?
typescript-bot
removed
the
Owner Approved
|
@yoursunny Thanks for your correction. Now interface |
|
@yoursunny, @mcollina Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
typescript-bot
added
the
Owner Approved
|
@mcollina Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
typescript-bot
added
the
Has Merge Conflict
|
@FuuuOverclocking Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
typescript-bot
removed
Has Merge Conflict
|
Hello, is anyone here? Please let me know if there is any problem with PR or merge. |
typescript-bot
added
the
Unreviewed
|
Re-ping @microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
typescript-bot
added
The CI failed
|
@FuuuOverclocking The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
typescript-bot
added
The CI failed
|
@FuuuOverclocking The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
Now the changes have also been applied to v16. The failure of CI seems to be caused by the new version 4.8 of TypeScript. It has nothing to do with this PR. |
typescript-bot
added
the
Owner Approved
typescript-bot
removed
Owner Approved
|
@peterblazejewicz, @mcollina, @yoursunny Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@peterblazejewicz, @yoursunny Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
typescript-bot
added
the
Owner Approved
typescript-bot
added
Maintainer Approved
Self Merge
|
@FuuuOverclocking: Everything looks good here. I am ready to merge this PR (at 93903f7) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina: you can do this too.) |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
If removing a declaration:
notNeededPackages.json.options.filteroffs.cp(src, dest[, options], callback)andfsPromises.cp(src, dest[, options])can return a Promise that resolves to true or false, according to documents.Also change the arguments' names to match the ones in jsdoc.