Skip to content

[react-dom] Update unstable entrypoints #59749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typescript-bot merged 2 commits into from
Apr 14, 2022
Merged

[react-dom] Update unstable entrypoints #59749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d7e6df
[react-dom] Update unstable entrypoints
eps1lon Apr 7, 2022
00b9bb9
Update instructions to keep types synced
eps1lon Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions types/react-dom/experimental.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,22 +24,12 @@
* Either the import or the reference only needs to appear once, anywhere in the project.
*/

// See https://github.com/facebook/react/blob/master/packages/react-dom/src/client/ReactDOM.js to see how the exports are declared,
// and https://github.com/facebook/react/blob/master/packages/shared/ReactFeatureFlags.js to verify which APIs are
// flagged experimental or not. Experimental APIs will be tagged with `__EXPERIMENTAL__`.
// See https://github.com/facebook/react/blob/main/packages/react-dom/index.experimental.js to see how the exports are declared,
// but confirm with published source code (e.g. https://unpkg.com/react-dom@experimental) that these exports end up in the published code

import React = require('react');
import ReactDOM = require('./next');

export {};

declare module '.' {
function unstable_flushControlled(callback: () => void): void;

// enableSelectiveHydration feature

/**
* @see https://github.com/facebook/react/commit/3a2b5f148d450c69aab67f055fc441d294c23518
*/
function unstable_scheduleHydration(target: Element | Document | DocumentFragment | Comment): void;
}
declare module '.' {}
3 changes: 2 additions & 1 deletion types/react-dom/next.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
* Either the import or the reference only needs to appear once, anywhere in the project.
*/

// See https://github.com/facebook/react/blob/master/packages/react-dom/src/client/ReactDOM.js to see how the exports are declared,
// See https://github.com/facebook/react/blob/main/packages/react-dom/index.js to see how the exports are declared,
// but confirm with published source code (e.g. https://unpkg.com/react-dom@next) that these exports end up in the published code

import React = require('react');
import ReactDOM = require('.');
Expand Down
8 changes: 0 additions & 8 deletions types/react-dom/test/experimental-tests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,2 @@
import ReactDOM = require('react-dom');
import 'react-dom/experimental';

// NOTE: I don't know yet how to use this; this is just the type it expects
// in reality it will do nothing because the root isn't hydrate: true
ReactDOM.unstable_scheduleHydration(document);

function updates() {
ReactDOM.unstable_flushControlled(() => {});
}