[react-dom] Remove /node-stream entrypoint#59747
[react-dom] Remove /node-stream entrypoint#59747typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59747,
"author": "eps1lon",
"headCommitOid": "8af38daa0ff0e51727490a9131090f6aa50d3c8f",
"mergeBaseOid": "874cc2c78ac01b0c7c32bddef4d660d2bf71bc5b",
"lastPushDate": "2022-04-25T07:00:51.000Z",
"lastActivityDate": "2022-04-25T17:17:55.000Z",
"mergeOfferDate": "2022-04-25T16:40:06.000Z",
"mergeRequestDate": "2022-04-25T17:17:55.000Z",
"mergeRequestUser": "eps1lon",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react-dom",
"kind": "edit",
"files": [
{
"path": "types/react-dom/v15/node-stream/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-dom/v15/react-dom-tests.ts",
"kind": "test"
},
{
"path": "types/react-dom/v16/node-stream/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-dom/v16/test/react-dom-tests.tsx",
"kind": "test"
},
{
"path": "types/react-dom/v17/node-stream/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-dom/v17/test/react-dom-tests.tsx",
"kind": "test"
}
],
"owners": [
"MartynasZilinskas",
"theruther4d",
"Jessidhia",
"eps1lon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2022-04-25T16:39:25.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1092085159,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Author is Owner
|
🔔 @MartynasZilinskas @theruther4d @Jessidhia — please review this PR in the next few days. Be sure to explicitly select |
|
I poked around the react repo and it looks like these were added in facebook/react#10024 for v16 then renamed in facebook/react#10425 and already exist as top level server functions |
|
Ah they were moved to |
eps1lon
changed the title
eps1lon
force-pushed
the
fix/react-dom/node-stream-entrypoint
branch
from
75134f2 to
8af38da
Compare
|
@jakebailey Thanks for catching this! Updated the v16 and v17 tests instead of just removing the |
typescript-bot
added
Maintainer Approved
Self Merge
|
@eps1lon: Everything looks good here. I am ready to merge this PR (at 8af38da) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@MartynasZilinskas, @theruther4d, @Jessidhia: you can do this too.) |
|
Ready to merge |
3 participants
This entrypoint was added in #18493 which was during the 16 beta time. It was then accidentally included in the v15 fork.
The entrypoint never made it to stable releases. Instead,
renderToStreamgot introduced asrenderToNodeStreaminreact-dom/serverandrenderToStaticStreamgot introduced asrenderToStaticNodeStreaminreact-dom/serverhttps://unpkg.com/browse/[email protected]/ -> https://unpkg.com/browse/[email protected]/lib/ReactDOMServer.js (no streaming related APIs)
https://unpkg.com/browse/[email protected]/ -> https://unpkg.com/browse/[email protected]/cjs/react-dom-server.node.development.js (check the
ReactDOMServerNodeEntry)https://unpkg.com/browse/[email protected]/ -> https://unpkg.com/browse/[email protected]/cjs/react-dom-server.node.development.js (check the
exports.*entries)