Skip to content

update(validator): add `isTaxID' validator #59426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
typescript-bot merged 1 commit into from
Mar 25, 2022
Merged

update(validator): add `isTaxID' validator #59426

typescript-bot merged 1 commit into from
Mar 25, 2022

Conversation

@peterblazejewicz
Copy link
Member

@peterblazejewicz peterblazejewicz commented Mar 23, 2022

validatorjs/validator.js#1867

Thanks!

Fixes #59419

/cc @wejesuss

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Run npm test <package to test>.

@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 23, 2022 •
edited
Loading

@peterblazejewicz Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect DT infrastructure (types/validadtor)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 59426,
  "author": "peterblazejewicz",
  "headCommitOid": "148da340d5ab549b175d2671800159a5e5e79713",
  "mergeBaseOid": "45af9020a0c6614d96e8641ffadcd3ceff882105",
  "lastPushDate": "2022-03-23T21:55:26.000Z",
  "lastActivityDate": "2022-03-25T18:46:35.000Z",
  "mergeOfferDate": "2022-03-24T00:23:31.000Z",
  "mergeRequestDate": "2022-03-25T18:46:35.000Z",
  "mergeRequestUser": "peterblazejewicz",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "types/validadtor",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "validator",
      "kind": "edit",
      "files": [
        {
          "path": "types/validator/es/lib/isTaxID.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/lib/isTaxID.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/validator/validator-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "tgfjt",
        "chrootsu",
        "IOAyman",
        "louy",
        "deptno",
        "builtinnya",
        "qqilihq",
        "keatz55",
        "MunifTanjim",
        "vlapo",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "tgfjt",
      "date": "2022-03-25T12:27:47.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "amcasey",
      "date": "2022-03-24T00:22:53.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1076845292,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Mar 23, 2022
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 23, 2022

🔔 @tgfjt @chrootsu @IOAyman @louy @deptno @builtinnya @qqilihq @keatz55 @MunifTanjim @vlapo — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Mar 23, 2022
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 23, 2022

@peterblazejewicz The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added Edits Infrastructure and removed Author is Owner The author of this PR is a listed owner of the package. The CI failed When GH Actions fails labels Mar 23, 2022
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 24, 2022
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 24, 2022

@peterblazejewicz: Everything looks good here. I am ready to merge this PR (at 148da34) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@tgfjt, @chrootsu, @IOAyman, @louy, @deptno, @builtinnya, @qqilihq, @keatz55, @MunifTanjim, @vlapo: you can do this too.)

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Mar 25, 2022
@peterblazejewicz
Copy link
Member Author

peterblazejewicz commented Mar 25, 2022

Ready to merge 💘

@typescript-bot typescript-bot merged commit d56db8d into DefinitelyTyped:master Mar 25, 2022
@peterblazejewicz peterblazejewicz deleted the update/validator branch March 25, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tgfjt tgfjt tgfjt approved these changes

@amcasey amcasey amcasey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Critical package Edits Infrastructure Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peterblazejewicz @typescript-bot @tgfjt @amcasey