Skip to content

(marked) Add export map and esm entrypoint #57236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weswigham merged 1 commit into from
Nov 18, 2021
Merged

(marked) Add export map and esm entrypoint #57236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions types/marked/OTHER_FILES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
index.d.mts
1 change: 1 addition & 0 deletions types/marked/index.d.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from "./index.js";
Copy link
Copy Markdown
Contributor

@UziTech UziTech Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is index.js referring to here? should it be index.d.ts?

Copy link
Copy Markdown
Contributor Author

@weswigham weswigham Nov 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah - esm imports have to have extensions and TS expects them to be the "output" extensions - so the js file extension (TS then maps that back to the declaration file internally).

11 changes: 11 additions & 0 deletions types/marked/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"private": true,
"exports": {
".": {
"types": {
"import": "./index.d.mts",
"default": "./index.d.ts"
}
}
}
}