Skip to content

Update node.d.ts#5654

Merged
vvakame merged 1 commit intoDefinitelyTyped:masterfrom
sledorze:master
Sep 3, 2015
Merged

Update node.d.ts#5654
vvakame merged 1 commit intoDefinitelyTyped:masterfrom
sledorze:master

Conversation

vvakame added a commit that referenced this pull request Sep 3, 2015
@vvakame vvakame merged commit 9ce3cd4 into DefinitelyTyped:master Sep 3, 2015
@vvakame
Copy link
Copy Markdown
Member

vvakame commented Sep 3, 2015

@sledorze thanks mate!

typescript-bot pushed a commit that referenced this pull request Nov 22, 2022
@andoks

* plotly.js: add missing hover modebar button strings supported by modeBarButtonsToAdd

Add the missing hover-related default-button strings as supported in
[plotly.js 2.12][]. Of particular importance is perhaps the v1hovermode
which restores the default modebar buttons from plotly v1 (see [PR:
Hide hover and spike modebar buttons...  #5654][]).

Also add a test for using the values in modeBarButtonsToAdd

[plotly.js 2.12]: <https://github.com/plotly/plotly.js/blob/v2.12.0/src/components/modebar/manage.js#L235>
[PR:  Hide hover and spike modebar buttons...  #5654]: <plotly/plotly.js#5654>

* plotly.js: allow mixing predefined and custom modebar-buttons

Also test that passing both predefined button strings and custom button
structs works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants