[carbon-components-react] Checkbox accepts a ref#56414
[carbon-components-react] Checkbox accepts a ref#56414typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
Checkbox accepts a ref#56414Conversation
eps1lon
force-pushed
the
fix/no-usage/RefForwardingComponent
branch
from
b17a5a6 to
1fb3d37
Compare
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 56414,
"author": "eps1lon",
"headCommitOid": "1fb3d37b8ebac9348dc14cd0f74fe50afefaebcf",
"lastPushDate": "2021-10-10T10:02:12.000Z",
"lastActivityDate": "2021-10-11T13:27:21.000Z",
"mergeOfferDate": "2021-10-11T13:25:40.000Z",
"mergeRequestDate": "2021-10-11T13:27:21.000Z",
"mergeRequestUser": "kalbert312",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "carbon-components-react",
"kind": "edit",
"files": [
{
"path": "types/carbon-components-react/carbon-components-react-tests.tsx",
"kind": "test"
},
{
"path": "types/carbon-components-react/lib/components/Checkbox/Checkbox.d.ts",
"kind": "definition"
}
],
"owners": [
"kalbert312",
"sgregoire",
"matchilling"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "kalbert312",
"date": "2021-10-11T13:25:03.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 939446290,
"ciResult": "pass"
} |
|
🔔 @kalbert312 @sgregoire @matchilling — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
Owner Approved
|
@eps1lon: Everything looks good here. I am ready to merge this PR (at 1fb3d37) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@kalbert312, @sgregoire, @matchilling: you can do this too.) |
|
Ready to merge |
3 participants
Noticed during work for #46691
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
[ ]If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.