fix(node-fetch): Change incorrect [string] to string#54674
Merged
weswigham merged 1 commit intoDefinitelyTyped:masterfrom Jul 22, 2021
Merged
fix(node-fetch): Change incorrect [string] to string#54674weswigham merged 1 commit intoDefinitelyTyped:masterfrom
weswigham merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
Contributor
|
@wjhsf Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 54674,
"author": "wjhsf",
"headCommitOid": "7fca3a4a3a21e46912017ce54e4dce87916da0bc",
"lastPushDate": "2021-07-22T02:24:04.000Z",
"lastActivityDate": "2021-07-22T10:03:31.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node-fetch",
"kind": "edit",
"files": [
{
"path": "types/node-fetch/index.d.ts",
"kind": "definition"
},
{
"path": "types/node-fetch/node-fetch-tests.ts",
"kind": "test"
}
],
"owners": [
"torstenwerner",
"nikcorg",
"vinaybedre",
"kyranet",
"AndrewLeedham",
"JasonLi914",
"southpolesteve",
"ExE-Boss",
"alexandrusavin",
"OmgImAlexis",
"kbkk"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "AndrewLeedham",
"date": "2021-07-22T10:03:31.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "nikcorg",
"date": "2021-07-22T09:18:32.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "kyranet",
"date": "2021-07-22T08:25:26.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "OmgImAlexis",
"date": "2021-07-22T02:35:12.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 884618007,
"ciResult": "pass"
} |
Contributor
|
🔔 @torstenwerner @nikcorg @vinaybedre @kyranet @AndrewLeedham @JasonLi914 @southpolesteve @ExE-Boss @alexandrusavin @OmgImAlexis @kbkk — please review this PR in the next few days. Be sure to explicitly select |
Contributor
|
LGTM |
OmgImAlexis
approved these changes
Jul 22, 2021
typescript-bot
added
the
Owner Approved
kyranet
approved these changes
Jul 22, 2021
nikcorg
approved these changes
Jul 22, 2021
AndrewLeedham
approved these changes
Jul 22, 2021
Contributor
|
I just published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current definition for
Headershasvalues(): IterableIterator<[string]>. The implementation is actuallyvalues(): IterableIterator<string>(spec compliant).npm test <package to test>.If changing an existing definition: