Add undefined to optional properties, Express to He by sandersn · Pull Request #54321 · DefinitelyTyped/DefinitelyTyped

sandersn · 2021-07-06T18:26:52Z

In preparation for exactOptionalPropertyTypes in Typescript 4.4, add undefined to all optional properties. #no-publishing-comment

This PR covers widely used packages (more than 100,000 downloads per month) from express-rate-limit -- he.
microsoft/dtslint#335

In preparation for exactOptionalPropertyTypes in Typescript 4.4, add undefined to all optional properties. #no-publishing-comment This PR covers widely used packages (more than 100,000 downloads per month) from express-rate-limit -- he. microsoft/dtslint#335

typescript-bot · 2021-07-06T18:28:34Z

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

75 packages in this PR

express-rate-limit — on npm, on unpkg
express-serve-static-core — on npm, on unpkg
express-session — on npm, on unpkg
express-unless — on npm, on unpkg
express — on npm, on unpkg
extract-files — on npm, on unpkg
extract-text-webpack-plugin — on npm, on unpkg
fabric — on npm, on unpkg
facebook-js-sdk — on npm, on unpkg
factory-girl — on npm, on unpkg
faker — on npm, on unpkg
fast-levenshtein — on npm, on unpkg
favicons — on npm, on unpkg
fb-watchman — on npm, on unpkg
fbjs — on npm, on unpkg
fetch-mock — on npm, on unpkg
fibers — on npm, on unpkg
figlet — on npm, on unpkg
file-entry-cache — on npm, on unpkg
file-loader — on npm, on unpkg
filesystem — on npm, on unpkg
finalhandler — on npm, on unpkg
find-cache-dir — on npm, on unpkg
find-package-json — on npm, on unpkg
fined — on npm, on unpkg
flat — on npm, on unpkg
follow-redirects — on npm, on unpkg
fontfaceobserver — on npm, on unpkg
forever-agent — on npm, on unpkg
formidable — on npm, on unpkg
friendly-errors-webpack-plugin — on npm, on unpkg
from2 — on npm, on unpkg
fs-extra — on npm, on unpkg
ftp — on npm, on unpkg
functional-red-black-tree — on npm, on unpkg
gapi.auth2 — on npm, on unpkg
gapi.client — on npm, on unpkg
gapi — on npm, on unpkg
gaze — on npm, on unpkg
generic-pool — on npm, on unpkg
geojson — on npm, on unpkg
get-value — on npm, on unpkg
getpass — on npm, on unpkg
git-url-parse — on npm, on unpkg
glob-parent — on npm, on unpkg
glob-stream — on npm, on unpkg
glob-to-regexp — on npm, on unpkg
glob — on npm, on unpkg
globule — on npm, on unpkg
google-map-react — on npm, on unpkg
google-protobuf — on npm, on unpkg
google.analytics — on npm, on unpkg
google.maps — on npm, on unpkg
google.visualization — on npm, on unpkg
googlepay — on npm, on unpkg
got — on npm, on unpkg
graphlib — on npm, on unpkg
graphql-upload — on npm, on unpkg
grecaptcha — on npm, on unpkg
gtag.js — on npm, on unpkg
gulp-concat — on npm, on unpkg
gulp-rename — on npm, on unpkg
gulp-util — on npm, on unpkg
gulp — on npm, on unpkg
hammerjs — on npm, on unpkg
hapi — on npm, on unpkg
hapi__catbox — on npm, on unpkg
hapi__hapi — on npm, on unpkg
hapi__joi — on npm, on unpkg
hapi__mimos — on npm, on unpkg
hapi__shot — on npm, on unpkg
har-format — on npm, on unpkg
hast — on npm, on unpkg
hawk — on npm, on unpkg
he — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
❌ Continuous integration tests have failed
🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 54321,
  "author": "sandersn",
  "headCommitOid": "7d8054359af4c5b1f16687c552c2fbccf4453e32",
  "lastPushDate": "2021-07-06T18:26:02.000Z",
  "lastActivityDate": "2021-07-06T20:24:15.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "express-rate-limit",
      "kind": "edit",
      "files": [
        {
          "path": "types/express-rate-limit/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/express-rate-limit/v2/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/express-rate-limit/v3/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "cyrilschumacher",
        "makepost",
        "jdforsythe",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "express-serve-static-core",
      "kind": "edit",
      "files": [
        {
          "path": "types/express-serve-static-core/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "borisyankov",
        "19majkel94",
        "kacepe",
        "micksatana",
        "samijaber",
        "JoseLion",
        "dwrss",
        "andoshin11"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "express-session",
      "kind": "edit",
      "files": [
        {
          "path": "types/express-session/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "horiuchi",
        "jacobbogers",
        "builtinnya",
        "ry7n",
        "fiznool",
        "peterblazejewicz",
        "HoldYourWaffle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "express-unless",
      "kind": "edit",
      "files": [
        {
          "path": "types/express-unless/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "wokim",
        "joaovieira",
        "michal-b-kaminski"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "express",
      "kind": "edit",
      "files": [
        {
          "path": "types/express/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "borisyankov",
        "CMUH",
        "puneetar",
        "dfrankland"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "extract-files",
      "kind": "edit",
      "files": [
        {
          "path": "types/extract-files/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Slessi",
        "lynxtaa"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "extract-text-webpack-plugin",
      "kind": "edit",
      "files": [
        {
          "path": "types/extract-text-webpack-plugin/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "flying-sheep",
        "katyo"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "fabric",
      "kind": "edit",
      "files": [
        {
          "path": "types/fabric/fabric-impl.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/fabric/test/index.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "oklemencic",
        "joewashear007",
        "mrand01",
        "NotWoods",
        "bmartinson",
        "RogerioTeixeira",
        "BradleyHill",
        "bmkrol823",
        "glenngartner",
        "codertx",
        "mike667",
        "nataliemarleny",
        "buzzyboy"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "facebook-js-sdk",
      "kind": "edit",
      "files": [
        {
          "path": "types/facebook-js-sdk/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "amritk",
        "mahmoudzohdi",
        "fluidsonic",
        "bengry"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "factory-girl",
      "kind": "edit",
      "files": [
        {
          "path": "types/factory-girl/factory-girl-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/factory-girl/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "stackbuilders",
        "sestrella",
        "elcuy",
        "OlivierKamers",
        "DMcNamara"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "faker",
      "kind": "edit",
      "files": [
        {
          "path": "types/faker/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/faker/v3/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "bensw",
        "basp",
        "Kuniwak",
        "mattbishop",
        "testica",
        "TastefulElk",
        "damonpam",
        "heavenshell",
        "pkuczynski",
        "p-j"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "fast-levenshtein",
      "kind": "edit",
      "files": [
        {
          "path": "types/fast-levenshtein/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mizunashi-mana"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "favicons",
      "kind": "edit",
      "files": [
        {
          "path": "types/favicons/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mohsen1",
        "metsawyr",
        "arturovt",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "fb-watchman",
      "kind": "edit",
      "files": [
        {
          "path": "types/fb-watchman/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "whtsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "fbjs",
      "kind": "edit",
      "files": [
        {
          "path": "types/fbjs/lib/fetchWithRetries.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "morrys"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "fetch-mock",
      "kind": "edit",
      "files": [
        {
          "path": "types/fetch-mock/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/fetch-mock/v6/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "asvetliakov",
        "tamird",
        "merrywhether",
        "chrissinclair",
        "matttennison",
        "quentinbouygues",
        "mtsmfm",
        "captain-igloo",
        "ChenNima",
        "dobogo"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "fibers",
      "kind": "edit",
      "files": [
        {
          "path": "types/fibers/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "soywiz",
        "smac89"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "figlet",
      "kind": "edit",
      "files": [
        {
          "path": "types/figlet/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "DefinitelyTyped"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "file-entry-cache",
      "kind": "edit",
      "files": [
        {
          "path": "types/file-entry-cache/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "file-loader",
      "kind": "edit",
      "files": [
        {
          "path": "types/file-loader/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "g-rath"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "filesystem",
      "kind": "edit",
      "files": [
        {
          "path": "types/filesystem/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "finalhandler",
      "kind": "edit",
      "files": [
        {
          "path": "types/finalhandler/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chrootsu",
        "hbomark"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "find-cache-dir",
      "kind": "edit",
      "files": [
        {
          "path": "types/find-cache-dir/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/find-cache-dir/v2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "BendingBender",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "find-package-json",
      "kind": "edit",
      "files": [
        {
          "path": "types/find-package-json/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "BendingBender",
        "fun4wut"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "fined",
      "kind": "edit",
      "files": [
        {
          "path": "types/fined/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "flat",
      "kind": "edit",
      "files": [
        {
          "path": "types/flat/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chrootsu",
        "thewizarodofoz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "follow-redirects",
      "kind": "edit",
      "files": [
        {
          "path": "types/follow-redirects/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "forivall",
        "claasahl",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "fontfaceobserver",
      "kind": "edit",
      "files": [
        {
          "path": "types/fontfaceobserver/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "RandScullard"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "forever-agent",
      "kind": "edit",
      "files": [
        {
          "path": "types/forever-agent/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "yavanosta"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "formidable",
      "kind": "edit",
      "files": [
        {
          "path": "types/formidable/FormidableError.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/formidable/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Nemo157",
        "martin-badin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "friendly-errors-webpack-plugin",
      "kind": "edit",
      "files": [
        {
          "path": "types/friendly-errors-webpack-plugin/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "bahlo"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "from2",
      "kind": "edit",
      "files": [
        {
          "path": "types/from2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "fs-extra",
      "kind": "edit",
      "files": [
        {
          "path": "types/fs-extra/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/fs-extra/v4/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/fs-extra/v8/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alan-agius4",
        "midknight41",
        "shiftkey",
        "mees-",
        "jrockwood",
        "sangdth",
        "ffflorian",
        "peterblazejewicz",
        "NotWoods"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "ftp",
      "kind": "edit",
      "files": [
        {
          "path": "types/ftp/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "rogierschouten",
        "TooTallNate"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "functional-red-black-tree",
      "kind": "edit",
      "files": [
        {
          "path": "types/functional-red-black-tree/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "CamWass"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "gapi.auth2",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.auth2/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "flawless2011"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "gapi.client",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "gapi",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "sgtfrankieboy",
        "grant"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "gaze",
      "kind": "edit",
      "files": [
        {
          "path": "types/gaze/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "adamzerella"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "generic-pool",
      "kind": "edit",
      "files": [
        {
          "path": "types/generic-pool/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jerray",
        "wrboyce"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "geojson",
      "kind": "edit",
      "files": [
        {
          "path": "types/geojson/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "cobster",
        "atd-schubert",
        "JeffJacobson",
        "icholy",
        "danvk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "get-value",
      "kind": "edit",
      "files": [
        {
          "path": "types/get-value/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "DanielRosenwasser",
        "TheMallen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "getpass",
      "kind": "edit",
      "files": [
        {
          "path": "types/getpass/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "claasahl"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "git-url-parse",
      "kind": "edit",
      "files": [
        {
          "path": "types/git-url-parse/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ajafff"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "glob-parent",
      "kind": "edit",
      "files": [
        {
          "path": "types/glob-parent/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mrmlnc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "glob-stream",
      "kind": "edit",
      "files": [
        {
          "path": "types/glob-stream/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Bartvds",
        "mrmlnc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "glob-to-regexp",
      "kind": "edit",
      "files": [
        {
          "path": "types/glob-to-regexp/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "whatasoda"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "glob",
      "kind": "edit",
      "files": [
        {
          "path": "types/glob/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/glob/v5/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "vvakame",
        "voy",
        "ajafff",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "globule",
      "kind": "edit",
      "files": [
        {
          "path": "types/globule/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "durad"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "google-map-react",
      "kind": "edit",
      "files": [
        {
          "path": "types/google-map-react/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "honzabrecka"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "google-protobuf",
      "kind": "edit",
      "files": [
        {
          "path": "types/google-protobuf/google/protobuf/api_pb.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-protobuf/google/protobuf/compiler/plugin_pb.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-protobuf/google/protobuf/descriptor_pb.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-protobuf/google/protobuf/struct_pb.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/google-protobuf/google/protobuf/type_pb.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "marcuslongmuir",
        "kamthamc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "google.analytics",
      "kind": "edit",
      "files": [
        {
          "path": "types/google.analytics/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tyler-murphy"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "google.maps",
      "kind": "edit",
      "files": [
        {
          "path": "types/google.maps/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jpoehnelt",
        "amuramoto"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "google.visualization",
      "kind": "edit",
      "files": [
        {
          "path": "types/google.visualization/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "danludwig",
        "gmoore-sjcorg",
        "danmana",
        "mlcheng",
        "IvanBisultanov",
        "glebm",
        "shrujalshah28",
        "dckorben",
        "martin-badin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "googlepay",
      "kind": "edit",
      "files": [
        {
          "path": "types/googlepay/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Fluccioni",
        "Radu-Raicea",
        "fstanis",
        "ozotek",
        "mumpo",
        "socsieng",
        "JlUgia"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "got",
      "kind": "edit",
      "files": [
        {
          "path": "types/got/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/got/v8/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "BendingBender",
        "LinusU",
        "ikokostya",
        "stijnvn",
        "wingsbob",
        "ryanwilsonperkin",
        "phawxby",
        "ivywit",
        "Huachao"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "graphlib",
      "kind": "edit",
      "files": [
        {
          "path": "types/graphlib/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "graphql-upload",
      "kind": "edit",
      "files": [
        {
          "path": "types/graphql-upload/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mike-marcacci"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "grecaptcha",
      "kind": "edit",
      "files": [
        {
          "path": "types/grecaptcha/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/grecaptcha/v0/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "DethAriel",
        "rafaeltavares",
        "RohrerF",
        "vkrol"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "gtag.js",
      "kind": "edit",
      "files": [
        {
          "path": "types/gtag.js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "rokt33r"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "gulp-concat",
      "kind": "edit",
      "files": [
        {
          "path": "types/gulp-concat/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "k-kagurazaka"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gulp-rename",
      "kind": "edit",
      "files": [
        {
          "path": "types/gulp-rename/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gulp-util",
      "kind": "edit",
      "files": [
        {
          "path": "types/gulp-util/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jedmao"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gulp",
      "kind": "edit",
      "files": [
        {
          "path": "types/gulp/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gulp/v3/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "GiedriusGrabauskas"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "hammerjs",
      "kind": "edit",
      "files": [
        {
          "path": "types/hammerjs/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hammerjs/v1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "milkisevil",
        "codler"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "hapi",
      "kind": "edit",
      "files": [
        {
          "path": "types/hapi/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hapi/test/server/server-app.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/test/server/server-auth-test.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/test/server/server-decorations.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/test/server/server-inject.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/test/server/server-options.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/test/server/server-path.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/test/server/server-settings.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/v12/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hapi/v15/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hapi/v16/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hapi/v16/test/route/plugins.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/v16/test/server/handler.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/v16/test/server/new.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/v17/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hapi/v17/test/server/server-app.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/v17/test/server/server-auth-test.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/v17/test/server/server-decorations.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/v17/test/server/server-inject.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/v17/test/server/server-options.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/v17/test/server/server-path.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/v17/test/server/server-settings.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi/v8/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "rafaelsouzaf",
        "jhsimms",
        "SimonSchick",
        "saboya"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "hapi__catbox",
      "kind": "edit",
      "files": [
        {
          "path": "types/hapi__catbox/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jasonswearingen",
        "AJamesPhillips",
        "saboya",
        "lenovouser"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "hapi__hapi",
      "kind": "edit",
      "files": [
        {
          "path": "types/hapi__hapi/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hapi__hapi/test/server/server-app.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi__hapi/test/server/server-auth-test.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi__hapi/test/server/server-decorations.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi__hapi/test/server/server-inject.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi__hapi/test/server/server-options.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi__hapi/test/server/server-path.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi__hapi/test/server/server-settings.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "rafaelsouzaf",
        "jhsimms",
        "SimonSchick",
        "saboya",
        "lenovouser"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "hapi__joi",
      "kind": "edit",
      "files": [
        {
          "path": "types/hapi__joi/hapi__joi-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/hapi__joi/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Bartvds",
        "laurence-myers",
        "cglantschnig",
        "DavidBR-SW",
        "GaelMagnan",
        "ralekna",
        "schfkt",
        "rokoroku",
        "dankraus",
        "wanganjun",
        "rafaelkallis",
        "aconanlai",
        "zaphoyd",
        "thewillg",
        "SimonSchick",
        "afharo",
        "lenovouser",
        "AnandChowdhary",
        "myovchev",
        "RecuencoJones",
        "freisenhauer",
        "legraphista",
        "SimchaWood",
        "stevendesu"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "hapi__mimos",
      "kind": "edit",
      "files": [
        {
          "path": "types/hapi__mimos/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "AJamesPhillips",
        "lenovouser",
        "LinusU",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "hapi__shot",
      "kind": "edit",
      "files": [
        {
          "path": "types/hapi__shot/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "AJamesPhillips",
        "SimonSchick",
        "lenovouser"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "har-format",
      "kind": "edit",
      "files": [
        {
          "path": "types/har-format/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "micmro",
        "marcelltoth"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "hast",
      "kind": "edit",
      "files": [
        {
          "path": "types/hast/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "lukeggchapman",
        "rokt33r",
        "ChristianMurphy"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "hawk",
      "kind": "edit",
      "files": [
        {
          "path": "types/hawk/lib/client.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hawk/lib/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hawk/lib/server.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/hawk/lib/utils.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ffflorian"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "he",
      "kind": "edit",
      "files": [
        {
          "path": "types/he/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "sedwards2009",
        "lokidokicoki"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 874987397,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/7d8054359af4c5b1f16687c552c2fbccf4453e32/checks?check_suite_id=3171957879"
}

typescript-bot · 2021-07-06T18:28:37Z

⚠️ There are too many reviewers for this PR change (197). Merging can only be handled by a DT maintainer.

People who would have been pinged

cyrilschumacher makepost jdforsythe peterblazejewicz borisyankov 19majkel94 kacepe micksatana samijaber JoseLion dwrss andoshin11 horiuchi jacobbogers builtinnya ry7n fiznool HoldYourWaffle wokim joaovieira michal-b-kaminski CMUH puneetar dfrankland Slessi lynxtaa flying-sheep katyo oklemencic joewashear007 mrand01 NotWoods bmartinson RogerioTeixeira BradleyHill bmkrol823 glenngartner codertx mike667 nataliemarleny buzzyboy amritk mahmoudzohdi fluidsonic bengry stackbuilders sestrella elcuy OlivierKamers DMcNamara bensw basp Kuniwak mattbishop testica TastefulElk damonpam heavenshell pkuczynski p-j mizunashi-mana mohsen1 metsawyr arturovt whtsky morrys asvetliakov tamird merrywhether chrissinclair matttennison quentinbouygues mtsmfm captain-igloo ChenNima dobogo soywiz smac89 DefinitelyTyped g-rath chrootsu hbomark BendingBender fun4wut thewizarodofoz forivall claasahl RandScullard yavanosta Nemo157 martin-badin bahlo alan-agius4 midknight41 shiftkey mees- jrockwood sangdth ffflorian rogierschouten TooTallNate CamWass flawless2011 Maxim-Mazurok sgtfrankieboy grant adamzerella jerray wrboyce cobster atd-schubert JeffJacobson icholy danvk DanielRosenwasser TheMallen ajafff mrmlnc Bartvds whatasoda vvakame voy durad honzabrecka marcuslongmuir kamthamc tyler-murphy jpoehnelt amuramoto danludwig gmoore-sjcorg danmana mlcheng IvanBisultanov glebm shrujalshah28 dckorben Fluccioni Radu-Raicea fstanis ozotek mumpo socsieng JlUgia LinusU ikokostya stijnvn wingsbob ryanwilsonperkin phawxby ivywit Huachao mike-marcacci DethAriel rafaeltavares RohrerF vkrol rokt33r k-kagurazaka jedmao GiedriusGrabauskas milkisevil codler rafaelsouzaf jhsimms SimonSchick saboya jasonswearingen AJamesPhillips lenovouser laurence-myers cglantschnig DavidBR-SW GaelMagnan ralekna schfkt rokoroku dankraus wanganjun rafaelkallis aconanlai zaphoyd thewillg afharo AnandChowdhary myovchev RecuencoJones freisenhauer legraphista SimchaWood stevendesu micmro marcelltoth lukeggchapman ChristianMurphy sedwards2009 lokidokicoki

typescript-bot · 2021-07-06T18:45:09Z

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

sandersn · 2021-07-06T20:24:15Z

mongoose dependents fail on master too.

sandersn requested review from Bartvds, DanielRosenwasser, borisyankov, horiuchi, peterblazejewicz and vvakame as code owners July 6, 2021 18:26

typescript-bot added Critical package Edits multiple packages Too Many Owners labels Jul 6, 2021

typescript-bot added the The CI failed When GH Actions fails label Jul 6, 2021

sandersn merged commit b24e5f6 into master Jul 6, 2021

sandersn deleted the Express-He-add-undefined-to-optional-properties branch July 6, 2021 20:25

josh- mentioned this pull request Jul 18, 2021

[google.visualization] Update options for Pie Chart to support its legend.position values #54134

Merged

17 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add undefined to optional properties, Express to He#54321

Add undefined to optional properties, Express to He#54321
sandersn merged 1 commit intomasterfrom
Express-He-add-undefined-to-optional-properties

sandersn commented Jul 6, 2021

Uh oh!

typescript-bot commented Jul 6, 2021 •

edited

Loading

Uh oh!

typescript-bot commented Jul 6, 2021

Uh oh!

typescript-bot commented Jul 6, 2021

Uh oh!

sandersn commented Jul 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sandersn commented Jul 6, 2021

Uh oh!

typescript-bot commented Jul 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

75 packages in this PR

Code Reviews

Status

Uh oh!

typescript-bot commented Jul 6, 2021

Uh oh!

typescript-bot commented Jul 6, 2021

Uh oh!

sandersn commented Jul 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

typescript-bot commented Jul 6, 2021 •

edited

Loading