@DetachHead Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• express-serve-static-core — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 10 days — please merge or say something if there's a problem, otherwise it will be closed!

{
  "type": "info",
  "now": "-",
  "pr_number": 53513,
  "author": "DetachHead",
  "headCommitOid": "b9a464f994255be107b466612d556c9b7701e900",
  "lastPushDate": "2021-06-17T10:45:54.000Z",
  "lastActivityDate": "2021-06-28T01:52:52.000Z",
  "mergeOfferDate": "2021-06-17T23:24:23.000Z",
  "mergeRequestDate": "2021-06-28T01:52:52.000Z",
  "mergeRequestUser": "DetachHead",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "express-serve-static-core",
      "kind": "edit",
      "files": [
        {
          "path": "types/express-serve-static-core/express-serve-static-core-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/express-serve-static-core/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/express-serve-static-core/ts4.0/express-serve-static-core-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "borisyankov",
        "19majkel94",
        "kacepe",
        "micksatana",
        "samijaber",
        "JoseLion",
        "dwrss",
        "andoshin11"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2021-06-17T23:23:45.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "JoseLion",
      "date": "2021-06-11T23:41:46.000Z",
      "abbrOid": "e9bc2f0"
    }
  ],
  "mainBotCommentID": 851396986,
  "ciResult": "pass"
}

🔔 @borisyankov @19majkel94 @kacepe @micksatana @samijaber @JoseLion @dwrss @andoshin11 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Re-ping @borisyankov, @19majkel94, @kacepe, @micksatana, @samijaber, @JoseLion, @dwrss, @andoshin11:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@JoseLion Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@DetachHead One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@rbuckton, @JoseLion Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@JoseLion Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Re-ping @DetachHead / @borisyankov, @19majkel94, @kacepe, @micksatana, @samijaber, @JoseLion, @dwrss, @andoshin11:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jul 17th (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

Ready to merge

I just published @types/[email protected] to npm.

the latest release, breaks one code line in my code... it seems it has troubles with routes like
/static-part/:param1/:param2/anotherstaticpart

src/routes/routes.ts:2616:9 - error TS2589: Type instantiation is excessively deep and possibly infinite.

2616         app.get('/website-api/jobalarm/:jobalarmId/:subscriptionId/search',
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2617             function JobalarmController_getJobAlarmSearchResultList(request: any, response: any, next: any) {
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 ... 
2637             promiseHandler(controller, promise, response, undefined, next);
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2638         });
     ~~~~~~~~~~

any known solution to this?

I tried adding <string,stirng> manually..this solves it, also the + "" hack, but the problem with this is: the file is auto generated, and it's not so easy to modify it. Therefore I would need a proper type solution I guess.

works with "@types/express-serve-static-core": "4.17.21", but not with 4.17.22.

@simllll sorry about that. #54151 will fix it

Wow nice for this quick follow up ! :-)