fix(pg-large-object): remove 3rd party library import#53432
Merged
peterblazejewicz merged 1 commit intoDefinitelyTyped:masterfrom May 27, 2021
Merged
fix(pg-large-object): remove 3rd party library import#53432peterblazejewicz merged 1 commit intoDefinitelyTyped:masterfrom
peterblazejewicz merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
The intent was to use Buffer (from Node), not custom Buffer (for browser). PG is for Node, not for browser and 3rd party Buffer is not whitelisted, so it impacted (best guess) recent failing CI tests. Thanks! see: DefinitelyTyped#52775 /cc @SimonSchick
Contributor
|
@peterblazejewicz Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes in this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 53432,
"author": "peterblazejewicz",
"headCommitOid": "cb4819d3ecf5d075ed0f4747cf37db8dcf09aa48",
"lastPushDate": "2021-05-27T06:53:14.000Z",
"lastActivityDate": "2021-05-27T14:55:00.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "pg-large-object",
"kind": "edit",
"files": [
{
"path": "types/pg-large-object/index.d.ts",
"kind": "definition"
},
{
"path": "types/pg-large-object/pg-large-object-tests.ts",
"kind": "test"
}
],
"owners": [
"mateuszkrupa"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "SimonSchick",
"date": "2021-05-27T14:55:00.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 849380648,
"ciResult": "pass"
} |
Contributor
|
🔔 @mateuszkrupa — please review this PR in the next few days. Be sure to explicitly select |
SimonSchick
approved these changes
May 27, 2021
typescript-bot
added
Other Approved
Contributor
|
I just published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAIK: the intent was to use Buffer (from Node), not custom Buffer (for
browser). PG is for Node, not for browser and 3rd party Buffer is not
whitelisted, so it impacted (best guess) recent failing CI tests.
Thanks!
see: #52775
/cc @SimonSchick
npm test <package to test>.