Skip to content

Comments

node: crypto keyobject jwk support#52653

Closed
panva wants to merge 1 commit intoDefinitelyTyped:masterfrom
panva:node-crypto-jwk
Closed

node: crypto keyobject jwk support#52653
panva wants to merge 1 commit intoDefinitelyTyped:masterfrom
panva:node-crypto-jwk

Conversation

@panva
Copy link
Contributor

@panva panva commented Apr 29, 2021

Please fill in this template.

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 29, 2021 •
edited
Loading

@panva Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 52653,
  "author": "panva",
  "headCommitOid": "f4a4598ec248b24845d0d805498439a385ba3467",
  "lastPushDate": "2021-04-29T13:11:55.000Z",
  "lastActivityDate": "2021-04-29T13:41:53.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/crypto.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "KSXGitHub",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "nguymin4",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "Ryan-Willpower",
        "peterblazejewicz",
        "addaleax",
        "JasonHK",
        "victorperin",
        "ZYSzys"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/f4a4598ec248b24845d0d805498439a385ba3467/checks?check_suite_id=2612782152"
}

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 29, 2021

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK @victorperin @ZYSzys — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 29, 2021

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #52653 diff
Batch compilation
Memory usage (MiB) 131.6 132.4 +0.6%
Type count 26341 26391 0%
Assignability cache size 9307 9338 0%
Language service
Samples taken 46 46 0%
Identifiers in tests 46 46 0%
getCompletionsAtPosition
    Mean duration (ms) 859.0 737.9 -14.1%
    Mean CV 8.4% 10.9%
    Worst duration (ms) 1051.9 831.8 -20.9%
    Worst identifier a a
getQuickInfoAtPosition
    Mean duration (ms) 833.5 729.9 -12.4%
    Mean CV 9.0% 11.4%
    Worst duration (ms) 989.7 902.7 -8.8%
    Worst identifier a a

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. The CI failed When GH Actions fails labels Apr 29, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 29, 2021

@panva The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed The CI failed When GH Actions fails labels Apr 29, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 29, 2021

@panva The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@panva
Copy link
Contributor Author

panva commented Apr 29, 2021

mongoose tests failure is unrelated to this PR.

@SimonSchick SimonSchick mentioned this pull request Apr 29, 2021
Closed
8 tasks
@panva
Copy link
Contributor Author

panva commented Apr 29, 2021

merged into #52652 upon request from @SimonSchick

@panva panva closed this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Critical package Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. The CI failed When GH Actions fails

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@panva @typescript-bot