@kentakang Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• aws-lambda-fastify (new!) on npm, on unpkg
  • 1 added owner: ✎@kentakang
  • Config files to check:
    • aws-lambda-fastify/tsconfig.json: not the expected form

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 52398,
  "author": "kentakang",
  "headCommitOid": "18703921b64a9052f61d8c1e8e3d254abfd4f577",
  "lastPushDate": "2021-04-16T02:41:53.000Z",
  "lastActivityDate": "2021-04-16T02:41:53.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "aws-lambda-fastify",
      "kind": "add",
      "files": [
        {
          "path": "types/aws-lambda-fastify/aws-lambda-fastify-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/aws-lambda-fastify/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/aws-lambda-fastify/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/aws-lambda-fastify/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson)"
        },
        {
          "path": "types/aws-lambda-fastify/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "kentakang"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "ciResult": "pass"
}

🔔 @kentakang — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@kentakang The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to aws-lambda-fastify with its source on master.

I just published @types/[email protected] to npm.