Skip to content

Minor changes in output from TS handling builtin symbols as unique symbols #50919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 1 commit into from
Feb 24, 2021
Merged

Minor changes in output from TS handling builtin symbols as unique symbols #50919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions types/lodash/lodash-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5268,8 +5268,8 @@ fp.now(); // $ExpectType number
_.chain({ a: undefined }).get("a", defaultValue); // $ExpectType PrimitiveChain<false> | PrimitiveChain<true>
_.chain({ a: [1] }).get("a", []).map((val) => val.toFixed()); // $ExpectType CollectionChain<string>

fp.get(Symbol.iterator, []); // $ExpectType any
fp.get(Symbol.iterator)([]); // $ExpectType any
fp.get(Symbol.iterator, []); // $ExpectType any || () => IterableIterator<never>
fp.get(Symbol.iterator)([]); // $ExpectType any || () => IterableIterator<never>
fp.get([Symbol.iterator], []); // $ExpectType any
fp.get(1)("abc"); // $ExpectType string
fp.get("1")("abc"); // $ExpectType any
Expand Down Expand Up @@ -6960,7 +6960,7 @@ fp.now(); // $ExpectType number
_.chain("a.b[0]").property<SampleObject, number>(); // $ExpectType FunctionChain<(obj: SampleObject) => number>
_.chain(["a", "b", 0]).property<SampleObject, number>(); // $ExpectType FunctionChain<(obj: SampleObject) => number>
fp.property(Symbol.iterator)([]); // $ExpectType any
fp.property([Symbol.iterator], []); // $ExpectType any
fp.property([Symbol.iterator], []); // $ExpectType any || () => IterableIterator<never>
fp.property(1)("abc"); // $ExpectType string
}

Expand All @@ -6971,7 +6971,7 @@ fp.now(); // $ExpectType number
_.chain({}).propertyOf() as _.LoDashExplicitWrapper<(path: _.Many<_.PropertyName>) => any>;

fp.propertyOf(Symbol.iterator)([]); // $ExpectType any
fp.propertyOf([Symbol.iterator], []); // $ExpectType any
fp.propertyOf([Symbol.iterator], []); // $ExpectType any || () => IterableIterator<never>
fp.propertyOf(1)("abc"); // $ExpectType string
}

Expand Down
2 changes: 1 addition & 1 deletion types/webidl-conversions/webidl-conversions-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ conversions.any(any); // $ExpectType any
conversions.any(unknown); // $ExpectType unknown
conversions.any(options); // $ExpectType Options
conversions.any(RegExp); // $ExpectType RegExpConstructor
conversions.any(Symbol.toStringTag); // $ExpectType symbol
conversions.any(Symbol.toStringTag); // $ExpectType symbol || typeof toStringTag
Copy link
Copy Markdown
Contributor

@ExE-Boss ExE-Boss Jan 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect that the stringified type would be typeof Symbol.toStringTag and not just typeof toStringTag.

Copy link
Copy Markdown
Contributor Author

@weswigham weswigham Jan 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be if the test node printer specified an enclosingDeclaration for the node to be generated.


conversions.void(); // $ExpectType void
conversions.boolean(any, integerOptions); // $ExpectType boolean
Expand Down