feat(react): Support react-jsx and react-jsxdev #49701
Conversation
typescript-bot
added
Critical package
Author is Owner
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 49701,
"author": "eps1lon",
"headCommitAbbrOid": "8ce1f86",
"headCommitOid": "8ce1f86b77cb46d3db339c20d9fab54377589693",
"stalenessInDays": 0,
"lastPushDate": "2020-11-20T11:43:29.000Z",
"reopenedDate": "2020-11-20T12:10:52.000Z",
"lastCommentDate": "2020-11-20T13:16:19.000Z",
"maintainerBlessed": false,
"mergeOfferDate": "2020-11-20T12:18:16.000Z",
"mergeRequestDate": "2020-11-20T13:16:19.000Z",
"mergeRequestUser": "ferdaber",
"hasMergeConflict": false,
"isFirstContribution": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/OTHER_FILES.txt",
"kind": "package-meta-ok"
},
{
"path": "types/react/index.d.ts",
"kind": "definition"
},
{
"path": "types/react/jsx-dev-runtime.d.ts",
"kind": "definition"
},
{
"path": "types/react/jsx-runtime.d.ts",
"kind": "definition"
},
{
"path": "types/react/v15/OTHER_FILES.txt",
"kind": "package-meta-ok"
},
{
"path": "types/react/v15/index.d.ts",
"kind": "definition"
},
{
"path": "types/react/v15/jsx-dev-runtime.d.ts",
"kind": "definition"
},
{
"path": "types/react/v15/jsx-runtime.d.ts",
"kind": "definition"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"digiguru",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "johnnyreilly",
"date": "2020-11-20T12:17:39.000Z",
"isMaintainer": true
}
],
"ciResult": "pass"
} |
|
🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
Maintainer Approved
Self Merge
|
Thank you for jumping in so quickly overnight to resolve this 🙏🏻 |
|
Ready to merge |
|
I’m a bit surprised that 4.1 doesn’t require the jsx and jsx_dev callable signatures to be declared. Let’s keep a close eye on this |
|
@ferdaber When does this get promoted to npm? |
|
I just published |
|
I just published |
@jasonwilliams Typings for React 15 ( |
|
@eps1lon is React 17 covered? I had issues with Sorry if this is the wrong place to ask |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? These typings are for a version of react that doesn’t yet exist on master, so I’ve compared them with v16.9. Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
typescript-bot
added
the
Perf: Same
|
The work for React 17 is being tracked in #48971 |
Adds support for
"jsx": "react-jsx"and"jsx": "react-jsxdev"compiler options in TypeScript 4.1 (backports jsx-runtime*.d.ts from #48971).I don't know how I could test this in the DT repo. Ideally we could control the TS version + compiler options in a test matrix.
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.