Add swapLeftAndRightInRTL function type in ReactNative I18nManager library types by amerllica · Pull Request #48885 · DefinitelyTyped/DefinitelyTyped

amerllica · 2020-10-17T18:43:53Z

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
Follow the advice from the readme.
Avoid common mistakes.
Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

Provide a URL to documentation or source code which provides context for the suggested changes: <https://github.com/facebook/react-native/blob/master/Libraries/ReactNative/I18nManager.js>
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
Include tests for your changes

My explanation:
Actually, the swapLeftAndRightInRTL is function inside react-native library and it is useful for RTL languages, this function is existed in this link but doesn't exist inside the @types/react-native. So I decided to add it.

typescript-bot · 2020-10-17T18:44:29Z

@amerllica Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

react-native on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
❌ Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 48885,
  "author": "amerllica",
  "owners": [
    "alloy",
    "huhuanming",
    "iRoachie",
    "timwangdev",
    "kamal",
    "alexdunne",
    "swissmanu",
    "bm-software",
    "a-tarasyuk",
    "mvdam",
    "esemesek",
    "mrnickel",
    "souvik-ghosh",
    "nossbigg",
    "saranshkataria",
    "franzmoro",
    "tykus160",
    "jakebloom",
    "ceyhun",
    "mcmar",
    "theohdv",
    "TheSavior",
    "romain-faust",
    "bebebebebe",
    "Naturalclar",
    "chinesedfan",
    "vtolochk",
    "SychevSP",
    "RageBill",
    "sasurau4",
    "256hz",
    "doumart",
    "drmas",
    "akrger",
    "jeremybarbet",
    "ca057",
    "ds300",
    "natsathorn",
    "connectdotz",
    "TheWirv",
    "alexeymolchan",
    "alexbrazier"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "6484e77",
  "headCommitOid": "6484e770a2c7cdc9899b6768961cd84ab13adb1f",
  "mergeIsRequested": false,
  "stalenessInDays": 1,
  "lastPushDate": "2020-10-20T07:00:35.000Z",
  "lastCommentDate": "2020-10-20T13:54:00.000Z",
  "maintainerBlessed": true,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48885/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Critical",
  "newPackages": [],
  "packages": [
    "react-native"
  ],
  "files": [
    {
      "path": "types/react-native/index.d.ts",
      "kind": "definition",
      "package": "react-native"
    },
    {
      "path": "types/react-native/test/index.tsx",
      "kind": "test",
      "package": "react-native"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "reviewersWithStaleReviews": [
    {
      "reviewedAbbrOid": "60ee505",
      "reviewer": "ca057",
      "date": "2020-10-20T06:29:33Z"
    },
    {
      "reviewedAbbrOid": "8957957",
      "reviewer": "ca057",
      "date": "2020-10-19T06:30:41Z"
    },
    {
      "reviewedAbbrOid": "36ad762",
      "reviewer": "ca057",
      "date": "2020-10-18T00:40:10Z"
    }
  ],
  "approvalFlags": 0,
  "isChangesRequested": false
}

typescript-bot · 2020-10-17T18:44:30Z

🔔 @alloy @huhuanming @iRoachie @timwangdev @kamal @alexdunne @swissmanu @bm-software @a-tarasyuk @mvdam @Esemesek @mrnickel @souvik-ghosh @nossbigg @saranshkataria @franzmoro @tykus160 @jakebloom @ceyhun @mcmar @theohdv @TheSavior @romain-faust @bebebebebe @Naturalclar @chinesedfan @vtolochk @SychevSP @RageBill @sasurau4 @256hz @doumart @drmas @akrger @jeremybarbet @ca057 @ds300 @natsathorn @connectdotz @thewirv @alexeymolchan @alexbrazier — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

…ypes

typescript-bot · 2020-10-17T21:06:16Z

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#48885	diff
Batch compilation
Memory usage (MiB)	106.7	106.2	-0.5%
Type count	32444	32447	0%
Assignability cache size	8653	8653	0%

Language service
Samples taken	2119	2119	0%
Identifiers in tests	2785	2785	0%
`getCompletionsAtPosition`
Mean duration (ms)	378.2	381.9	+1.0%
Mean CV	7.2%	7.4%
Worst duration (ms)	566.1	587.1	+3.7%
Worst identifier	style	fadingEdgeLength
`getQuickInfoAtPosition`
Mean duration (ms)	375.5	379.5	+1.1%
Mean CV	7.2%	7.3%	+2.2%
Worst duration (ms)	527.0	550.1	+4.4%
Worst identifier	section	snapToOffsets

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

…n undefined

typescript-bot · 2020-10-19T05:55:24Z

@ca057 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

typescript-bot · 2020-10-20T06:30:10Z

@amerllica Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

# Conflicts: # types/react-native/test/index.tsx

alloy · 2020-10-22T12:50:50Z

Thanks!

typescript-bot · 2020-10-22T12:56:03Z

I just published @types/[email protected] to npm.

amerllica · 2020-10-25T22:31:36Z

@ca057 Vielen Dank 🌹

@alloy Thanks a lot 🌷

add swapLeftAndRightInRTL function type

de0d5f4

amerllica requested a review from alloy as a code owner October 17, 2020 18:43

typescript-bot added Critical package Untested Change This PR does not touch tests labels Oct 17, 2020

amerllica added 2 commits October 17, 2020 22:20

add doLeftAndRightSwapInRTL flag to ReactNative I18nManager library t…

0aa014f

…ypes

add getConstants function type to ReactNative I18nManager library types

36ad762

typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Oct 17, 2020

ca057 reviewed Oct 18, 2020

View reviewed changes

Comment thread types/react-native/index.d.ts Resolved

Add void instead of using empty curly brace for which functions retur…

8957957

…n undefined

Add a test for I18nManager type modification

60ee505

typescript-bot removed the Untested Change This PR does not touch tests label Oct 19, 2020

ca057 approved these changes Oct 20, 2020

View reviewed changes

typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Owner Approved A listed owner of this package signed off on the pull request. labels Oct 20, 2020

Merge branch 'master' of github.com:DefinitelyTyped/DefinitelyTyped

6484e77

# Conflicts: # types/react-native/test/index.tsx

typescript-bot removed Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Owner Approved A listed owner of this package signed off on the pull request. labels Oct 20, 2020

alloy merged commit 7a1d135 into DefinitelyTyped:master Oct 22, 2020

Navigation Menu

Repository navigation

Add swapLeftAndRightInRTL function type in ReactNative I18nManager library types - #48885

Add swapLeftAndRightInRTL function type in ReactNative I18nManager library types#48885
alloy merged 6 commits into
DefinitelyTyped:masterfrom
amerllica:master

amerllica commented Oct 17, 2020 •

edited

Loading

Uh oh!

typescript-bot commented Oct 17, 2020 •

edited

Loading

Uh oh!

typescript-bot commented Oct 17, 2020

Uh oh!

typescript-bot commented Oct 17, 2020

Uh oh!

Uh oh!

typescript-bot commented Oct 19, 2020

Uh oh!

typescript-bot commented Oct 20, 2020

Uh oh!

alloy commented Oct 22, 2020

Uh oh!

typescript-bot commented Oct 22, 2020

Uh oh!

amerllica commented Oct 25, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

amerllica commented Oct 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1 package in this PR

Code Reviews

Status

Uh oh!

typescript-bot commented Oct 17, 2020

Uh oh!

typescript-bot commented Oct 17, 2020

Uh oh!

Uh oh!

typescript-bot commented Oct 19, 2020

Uh oh!

typescript-bot commented Oct 20, 2020

Uh oh!

alloy commented Oct 22, 2020

Uh oh!

typescript-bot commented Oct 22, 2020

Uh oh!

amerllica commented Oct 25, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

amerllica commented Oct 17, 2020 •

edited

Loading

typescript-bot commented Oct 17, 2020 •

edited

Loading