@kryops Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

• webpack-bundle-analyzer on npm, on unpkg
• webpack on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ An owner or a DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 48857,
  "author": "kryops",
  "owners": [
    "kryops",
    "VladimirGrenaderov",
    "maxbogus",
    "peterblazejewicz",
    "tkqubo",
    "bumbleblym",
    "bcherny",
    "tommytroylin",
    "mohsen1",
    "jcreamer898",
    "alan-agius4",
    "dennispg",
    "christophehurpeau",
    "ZSkycat",
    "johnnyreilly",
    "rwaskiewicz",
    "kuehlein",
    "grgur",
    "rubenspgcavalcante",
    "andersk",
    "ofhouse",
    "danielthank",
    "sasurau4",
    "dionshihk",
    "spamshaker"
  ],
  "dangerLevel": "MultiplePackagesEdited",
  "headCommitAbbrOid": "ceb69de",
  "headCommitOid": "ceb69de4d181b5663f253092c8a1f35f9ef3294d",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-10-16T17:08:08.000Z",
  "lastCommentDate": "2020-10-20T15:09:29.000Z",
  "maintainerBlessed": true,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48857/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "newPackages": [],
  "packages": [
    "webpack-bundle-analyzer",
    "webpack"
  ],
  "files": [
    {
      "path": "types/webpack-bundle-analyzer/index.d.ts",
      "kind": "definition",
      "package": "webpack-bundle-analyzer"
    },
    {
      "path": "types/webpack-bundle-analyzer/webpack-bundle-analyzer-tests.ts",
      "kind": "test",
      "package": "webpack-bundle-analyzer"
    },
    {
      "path": "types/webpack/index.d.ts",
      "kind": "definition",
      "package": "webpack"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-10-16T18:01:54.000Z",
  "firstApprovalDate": "2020-10-16T18:01:54.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

🔔 @VladimirGrenaderov @maxbogus @peterblazejewicz @tkqubo @bumbleblym @bcherny @tommytroylin @mohsen1 @jcreamer898 @alan-agius4 @dennispg @christophehurpeau @ZSkycat @johnnyreilly @rwaskiewicz @kuehlein @grgur @rubenspgcavalcante @andersk @ofhouse @danielthank @sasurau4 @dionshihk @spamshaker — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@kryops The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Mentioning other webpack related definition authors to raise awareness so we're not all trying to solve the same problem at the same time. Sorry for the spam, please unsubscribe if this is irrelevant for you:

@AGenson @andersk @AviVahl @bahlo @blaise-io @bumbleblym @ChaosinaCan @danpintara @Danscho @davecardwell @deevus @dsifford @dublicator @e-cloud @flying-sheep @FranklinWhale @garbetjie @Hotell @huan086 @iclanton @inglec-arista @j-f1 @JounQin @JuanJoseGonGi @karol-majewski @katyo @kgroat @maestroh @malj @maxbogus @monsonjeremy @mtraynham @nhardy @odnamrataizem @pd4d10 @peterblazejewicz @pine @playma256 @r3nya @remcohaszing @rynclark @Seally @skovy @tkqubo @use-strict @vajkayrene @VladimirGrenaderov @woitechen

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

webpack-bundle-analyzer (unpkg)

was missing the following properties:

1. start

webpack (unpkg)

was missing the following properties:

1. WebpackOptionsDefaulter
2. WebpackOptionsApply
3. NodeEnvironmentPlugin
4. validate
5. validateSchema

Generated by 🚫 dangerJS against ceb69de

Hi, @types/webpack maintainer here,
Since it only adds an additional export here I am completely fine with this addition.

Most of the exported names came from a time ([email protected]) where there were no types or annotation in the webpack repo itself.
So the authors picked names that made sense to them at the time but they were never renamed when the webpack authors began to annotate the repo itself and gave them other names.
So it's not uncommon to find type names here that are different from the annotations available in webpack itself.

Changing all the names now makes no sense since this typings will be deprecated eventually. But when you find something that makes the upgrade to [email protected] easier and is a non-breaking change then you are welcome to add them.

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

webpack-bundle-analyzer/v*

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

webpack/v*

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

Ready to merge

I just published @types/[email protected] to npm.

I just published @types/[email protected] to npm.

thanks!