Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-native: add some missing props for TextInput #42279

Merged
merged 4 commits into from
Feb 12, 2020
Merged

react-native: add some missing props for TextInput #42279

merged 4 commits into from
Feb 12, 2020

Conversation

Naturalclar
Copy link
Contributor

Added passwordRules and rejectResponderTermination props for TextInput both props are for iOS.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@Naturalclar Naturalclar requested a review from alloy as a code owner February 11, 2020 17:38
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Author is Owner The author of this PR is a listed owner of the package. The Travis CI build failed labels Feb 11, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 11, 2020 •
edited
Loading

@Naturalclar Thank you for submitting this PR!

🔔 @alloy @huhuanming @iRoachie @Skn0tt @timwangdev @kamal @alexdunne @swissmanu @bm-software @a-tarasyuk @mvdam @Esemesek @mrnickel @souvik-ghosh @nossbigg @saranshkataria @franzmoro @tykus160 @jakebloom @ceyhun @mcmar @theohdv @TheSavior @romain-faust @bebebebebe @chinesedfan @vtolochk @SychevSP @RageBill @sasurau4 @256hz - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 11, 2020 •
edited
Loading

@Naturalclar The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #42279 diff
Batch compilation
Memory usage (MiB) 96.7 96.8 +0.1%
Type count 25933 25935 0%
Assignability cache size 22913 22913 0%
Language service
Samples taken 1813 1813 0%
Identifiers in tests 1813 1813 0%
getCompletionsAtPosition
    Mean duration (ms) 335.8 337.0 +0.4%
    Mean CV 8.7% 8.7%
    Worst duration (ms) 500.3 526.6 +5.3%
    Worst identifier top style
getQuickInfoAtPosition
    Mean duration (ms) 332.3 333.2 +0.3%
    Mean CV 8.8% 8.8% +0.5%
    Worst duration (ms) 480.9 470.7 -2.1%
    Worst identifier compose scrollToOverflowEnabled

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Feb 11, 2020
alloy
alloy requested changes Feb 12, 2020
View reviewed changes
Copy link
Collaborator

@alloy alloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small Maybe changes and CI failure, but otherwise 👍

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Feb 12, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 12, 2020 •
edited
Loading

@Naturalclar The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@alloy
Copy link
Collaborator

alloy commented Feb 12, 2020

Unsure how this didn’t surface earlier, but indeed this test file of another RN package has a syntax error:

DefinitelyTyped/types/react-native-popup-dialog/react-native-popup-dialog-tests.tsx

Line 92 in 28ff2e3

></Dialog>

Can you fix that in your PR?

@Naturalclar
Copy link
Contributor Author

@alloy sure! I've fixed the syntax error in react-native-popup-dialog

@alloy
Copy link
Collaborator

alloy commented Feb 12, 2020

Great, thanks! ✅

@alloy alloy merged commit 267dc9f into DefinitelyTyped:master Feb 12, 2020
@Naturalclar Naturalclar deleted the react-native/addPasswordRule branch February 12, 2020 16:42
@typescript-bot
Copy link
Contributor

I just published @types/[email protected] to npm.

@sandersn
Copy link
Contributor

@alloy Turns out we just merged a new syntax error for JSX yesterday. It caught me by surprise too.

@alloy
Copy link
Collaborator

alloy commented Feb 12, 2020

@sandersn Well, seems to work great! ✨

@alloy alloy mentioned this pull request Feb 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicwhite elicwhite elicwhite left review comments

@alloy alloy alloy requested changes

Assignees
No one assigned
Labels
Author is Owner The author of this PR is a listed owner of the package. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts). Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Naturalclar @typescript-bot @alloy @sandersn @elicwhite