Well... how to fix?

If an external module (in this case "acl") is split across multiple files you can only use stuff that has been exported.

Sorry. I've made it worse :) Investigating

I've provided the TS team with a sample : microsoft/TypeScript#2784

The reason why I thought I had a fix was that the files compile fine in isolation under different cases

So the fix recommended by the TS team (microsoft/TypeScript#2784 (comment)) is to use a ghost module. I'm thinking of calling it AclTypes 👍

Note: I'll do the work and commit in about 6 hours

So can't declare inside "foo" if it has an export = as only a single thing can have an export if we use export =. And if I move to AclTypes then I can't use import http = require("http")

So now I need to move stuff from "http" out into the ghost NodeJS module => other stuff that "http".ServerRequest depends upon like net and events needs to be moved too 😭

@vvakame are you okay with me completely opening up node.d.ts. Ofcourse it will be a lot of work and I might stumble on more refactoring needed in the process.

@basarat wow, thank you basarat! it is big incident...

----------------- For file:react/legacy/react-0.12-tests.ts
react/legacy/react-0.12.d.ts(927,5): error TS2309: An export assignment cannot be used in a module with other exported elements.

Hmm?

Hmm?

saw the same thing : microsoft/TypeScript#2784 (comment)

In this reduced example : microsoft/TypeScript#2784 (comment)

Basically there is an implicit export of Foo if its used in b.d.ts below:

a.d.ts (which compiles fine in isolation) without any error:

declare module "foo" {
    interface Foo {
        a: number;
    }
    var _:Foo;
    export = _;
}

And b.d.ts that plans to add stuff to module foo's Foo interface:

/// <reference path="./a"/>

declare module "foo" {
    interface Foo {
        b: number;
    }
}

@basarat It seems to do not reopen external module in react/legacy/react-0.12-tests.ts and react/legacy/react-0.12.d.ts. isn't it?

isn't it?

This is effectively what you did to fix acl as well

@basarat umm.. sorry, I am not understanding yet... can you make a commit?

can you make a commit?

Here is a sample:

It seems to do not reopen external module

Yes. Exactly.

Note I do not see this error in our case locally :

But I am on typescript master so perhaps worth pointing typescript to : https://github.com/Arnavion/typescript-github/releases/tag/2015-04-26-218e1012a2e671ca70be3c1b9edf0db092e4c5c2 Details : https://github.com/Arnavion/typescript-github#install

ready to merge! 7/20 is release day of VisualStudio 2015.

I think we need test bed of es6 target.
my proposal. test with --target es6 option if definition has *-tests.es6.ts postfix.

@basarat @horiuchi what do you think?

test with --target es6 option if definition has *-tests.es6.ts postfix

👍 from me

BTW thanks for all the hard work on this update 💯

✨ 😺 ✨

TypeScript 1.5.3 released!

oops. I I forgot update package.json...