Deprecate whatwg-streams in favor for DOM types#38785
Deprecate whatwg-streams in favor for DOM types#38785RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
TypeScript 3.2 shipped with built-in type definitions for streams, so this types package is no longer needed.
| "libraryName": "typescript", | ||
| "typingsPackageName": "whatwg-streams", | ||
| "sourceRepoURL": "https://streams.spec.whatwg.org", | ||
| "asOfVersion": "3.2.1" |
There was a problem hiding this comment.
I noticed that in other PRs that removed types for DOM APIs (e.g. #34641), the asOfVersion field is always set to 2.0.0. I'm not sure if there's a special reason for this?
I've put in the TypeScript version in which streams were added to the DOM types. If that's not how this field works, let me know. 🙂
|
@MattiasBuelens Thank you for submitting this PR! 🔔 @saschanaz @ksm2 - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
TypeScript 3.2 shipped with built-in type definitions for streams (see microsoft/TypeScript-DOM-lib-generator#541 and microsoft/TypeScript#28343), so this types package is no longer needed.
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If removing a declaration:
notNeededPackages.json.