Skip to content

[form-data] Remove @types/form-data since v2.5.0 it bundles types#36644

Closed
mapleeit wants to merge 2 commits intoDefinitelyTyped:masterfrom
mapleeit:feat/remove-form-data
Closed

[form-data] Remove @types/form-data since v2.5.0 it bundles types#36644
mapleeit wants to merge 2 commits intoDefinitelyTyped:masterfrom
mapleeit:feat/remove-form-data

Conversation

@mapleeit
Copy link
Copy Markdown

@mapleeit mapleeit commented Jul 4, 2019 •
edited
Loading

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If removing a declaration:

  • Delete the package's directory.
  • Add it to notNeededPackages.json.

This PR is waiting for microsoft/types-publisher#630 , so it's still WIP.

It's ready now.

@mapleeit mapleeit requested a review from Bartvds as a code owner July 4, 2019 07:28
@mapleeit mapleeit mentioned this pull request Jul 4, 2019
Merged
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). The Travis CI build failed labels Jul 4, 2019
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jul 4, 2019 •
edited
Loading

@mapleeit Thank you for submitting this PR!

🔔 @soywiz @leonyu @BendingBender @LinusU @ikokostya @stijnvn @wingsbob @ryanwilsonperkin @sampsonjoliver @andipaetzold @JiriBalcar @bonnici @Bartvds @joeskeen @ccurrens @lookfirst @mastermatt @josecolella @murbanowicz - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jul 4, 2019 •
edited
Loading

@mapleeit The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@mapleeit mapleeit changed the title WIP [form-data] Remove @types/form-data since v2.5.0 it bundles types [form-data] Remove @types/form-data since v2.5.0 it bundles types Jul 9, 2019
@mapleeit
Copy link
Copy Markdown
Author

mapleeit commented Jul 9, 2019 •
edited
Loading

microsoft/types-publisher#630 has been merged. Wondering how to trigger rebuilding now...

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jul 10, 2019

@mapleeit I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

@typescript-bot typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label Jul 11, 2019
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jul 11, 2019

@mapleeit To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you!

@mapleeit mapleeit deleted the feat/remove-form-data branch July 16, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bartvds Bartvds Awaiting requested review from Bartvds Bartvds is a code owner

Assignees

No one assigned

Labels

Abandoned This PR had no activity for a long time, and is considered abandoned Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mapleeit @typescript-bot