Skip to content

Remove excess proprty from hapi tests - #34701

Merged
weswigham merged 1 commit into
masterfrom
hapi-tests-remove-excess-prop
Apr 16, 2019
Merged

weswigham merged 1 commit into
masterfrom
hapi-tests-remove-excess-prop

Conversation

@weswigham

Copy link
Copy Markdown
Contributor

Found while working on microsoft/TypeScript#30853 - asd is never augmented into HandlerDecorations in any tests, so it's excess and, with the mentioned PR, an error.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Apr 12, 2019
@typescript-bot

typescript-bot commented Apr 12, 2019 •

Copy link
Copy Markdown
Contributor

@weswigham Thank you for submitting this PR!

🔔 @rafaelsouzaf @jhsimms @SimonSchick @saboya - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@weswigham
weswigham merged commit 9eb464e into master Apr 16, 2019
@weswigham
weswigham deleted the hapi-tests-remove-excess-prop branch April 16, 2019 23:44
weswigham added a commit that referenced this pull request Apr 17, 2019
Found while working on microsoft/TypeScript#30853 - asd is never augmented into HandlerDecorations in any tests, so it's excess and, with the mentioned PR, an error.

#34701 but again for the new location of the types, pretty much.
weswigham added a commit that referenced this pull request Apr 17, 2019
Found while working on microsoft/TypeScript#30853 - asd is never augmented into HandlerDecorations in any tests, so it's excess and, with the mentioned PR, an error.

#34701 but again for the new location of the types, pretty much.
alesn pushed a commit to alesn/DefinitelyTyped that referenced this pull request Apr 23, 2019
alesn pushed a commit to alesn/DefinitelyTyped that referenced this pull request Apr 23, 2019
Found while working on microsoft/TypeScript#30853 - asd is never augmented into HandlerDecorations in any tests, so it's excess and, with the mentioned PR, an error.

DefinitelyTyped#34701 but again for the new location of the types, pretty much.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants