Skip to content

Mark parameters in knockout test as optional #34699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weswigham merged 1 commit into from
Apr 12, 2019
Merged

Mark parameters in knockout test as optional #34699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/knockout/test/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ function test_Components() {
ko.components.register("name", { template: "string-template", viewModel: { instance: null } });

// viewModel from createViewModel factory method
ko.components.register("name", { template: "string-template", viewModel: { createViewModel: function (params: any, componentInfo: KnockoutComponentTypes.ComponentInfo) { return null; } } });
ko.components.register("name", { template: "string-template", viewModel: { createViewModel: function (params?: any, componentInfo?: KnockoutComponentTypes.ComponentInfo) { return null; } } });

// viewModel from an AMD module
ko.components.register("name", { template: "string-template", viewModel: { require: "module" } });
Expand Down