Skip to content

Add missing message field to DrawErrorOptions - #34698

Merged
armanio123 merged 1 commit into
masterfrom
add-missing-opt
Apr 15, 2019
Merged

armanio123 merged 1 commit into
masterfrom
add-missing-opt

Conversation

@weswigham

Copy link
Copy Markdown
Contributor

Found while working on microsoft/TypeScript#30853 - It seems to be used in the code which is linked when you look for the options docs, and is used in the test, so it seems to actually exist and was just missing from the type.

@typescript-bot

typescript-bot commented Apr 12, 2019 •

Copy link
Copy Markdown
Contributor

@weswigham Thank you for submitting this PR!

🔔 @Matt-Guest @reblace @YunS-Stacy @beschoenen - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Apr 13, 2019
@typescript-bot

Copy link
Copy Markdown
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@armanio123
armanio123 merged commit 4d48212 into master Apr 15, 2019
@typescript-bot

Copy link
Copy Markdown
Contributor

I just published @types/[email protected] to npm.

@weswigham
weswigham deleted the add-missing-opt branch April 15, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants