Skip to content

Fix typo in mangopay tests - #34697

Merged
armanio123 merged 1 commit into
masterfrom
fix-typo-in-mangopay
Apr 15, 2019
Merged

armanio123 merged 1 commit into
masterfrom
fix-typo-in-mangopay

Conversation

@weswigham

Copy link
Copy Markdown
Contributor

Found while working on microsoft/TypeScript#30853 - the weaker UpdateWallet type previously meant this this was assignable to the constructor type, even though it had a Currency field with the incorrect type.

@typescript-bot

typescript-bot commented Apr 12, 2019 •

Copy link
Copy Markdown
Contributor

@weswigham Thank you for submitting this PR!

🔔 @ifiokjr - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@weswigham weswigham changed the title Fix typo in magopay tests Fix typo in mangopay tests Apr 12, 2019
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Apr 14, 2019
@typescript-bot

Copy link
Copy Markdown
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@armanio123
armanio123 merged commit 4674c8b into master Apr 15, 2019
@weswigham
weswigham deleted the fix-typo-in-mangopay branch April 15, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants