Skip to content

Use secureOptions in request tests, not securityOptions #34680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uniqueiniquity merged 1 commit into from
Apr 12, 2019
Merged

Use secureOptions in request tests, not securityOptions #34680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion types/request-promise-native/request-promise-native-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import rpn = require('request-promise-native');
import * as errors from 'request-promise-native/errors';
import * as path from 'path';
import constants = require('constants');

rpn('http://www.google.com')
.then(console.dir)
Expand Down Expand Up @@ -336,7 +337,7 @@ options = {
// Or use `pfx` property replacing `cert` and `key` when using private key, certificate and CA certs in PFX or PKCS12 format:
// pfx: fs.readFileSync(pfxFilePath),
passphrase: 'password',
securityOptions: 'SSL_OP_NO_SSLv3'
secureOptions: constants.SSL_OP_NO_SSLv3
}
};

Expand Down
3 changes: 2 additions & 1 deletion types/request-promise/request-promise-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import rp = require('request-promise');
import errors = require('request-promise/errors');
import * as path from "path";
import constants = require('constants');

rp('http://www.google.com')
.then(console.dir)
Expand Down Expand Up @@ -355,7 +356,7 @@ options = {
// Or use `pfx` property replacing `cert` and `key` when using private key, certificate and CA certs in PFX or PKCS12 format:
// pfx: fs.readFileSync(pfxFilePath),
passphrase: 'password',
securityOptions: 'SSL_OP_NO_SSLv3'
secureOptions: constants.SSL_OP_NO_SSLv3
}
};

Expand Down
3 changes: 2 additions & 1 deletion types/request/request-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import qs = require('querystring');
import request = require('request');
import stream = require('stream');
import urlModule = require('url');
import constants = require('constants');

let value: any;
let str: string;
Expand Down Expand Up @@ -540,7 +541,7 @@ options = {
// Or use `pfx` property replacing `cert` and `key` when using private key, certificate and CA certs in PFX or PKCS12 format:
// pfx: fs.readFileSync(pfxFilePath),
passphrase: 'password',
securityOptions: 'SSL_OP_NO_SSLv3'
secureOptions: constants.SSL_OP_NO_SSLv3
}
};

Expand Down