Repository navigation
Remove unused conditions prop from revalidator test, add missing type… - #34679
Merged
Merged
Conversation
… and patternProperties fields
Contributor
|
@weswigham Thank you for submitting this PR! 🔔 @brewsoftware - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
Contributor
|
I just published |
alesn
pushed a commit
to alesn/DefinitelyTyped
that referenced
this pull request
Apr 23, 2019
… and patternProperties fields (DefinitelyTyped#34679)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… and patternProperties fields
Found while looking at microsoft/TypeScript#30853. The missing fields seem to be an oversight, and the
conditionsproperty used in the test is simply wholly imaginary from what I can tell, as it's not referenced in either the json schema spec or within the library's source.