Skip to content

[bookshelf] Adding withSchema to SyncOptions#33723

Merged
weswigham merged 1 commit into
DefinitelyTyped:masterfrom
minyoung:bookshelf-sync-with-schema
Mar 11, 2019
Merged

[bookshelf] Adding withSchema to SyncOptions#33723
weswigham merged 1 commit into
DefinitelyTyped:masterfrom
minyoung:bookshelf-sync-with-schema

Conversation

@minyoung

@minyoung minyoung commented Mar 8, 2019

Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: add withSchema support bookshelf/bookshelf#1638
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot

typescript-bot commented Mar 8, 2019

Copy link
Copy Markdown
Contributor

@minyoung Thank you for submitting this PR!

🔔 @arcticwaters @vesse - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Merge:LGTM labels Mar 9, 2019
@typescript-bot

typescript-bot commented Mar 11, 2019

Copy link
Copy Markdown
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Mar 11, 2019
@weswigham
weswigham merged commit d3b2bbc into DefinitelyTyped:master Mar 11, 2019
@typescript-bot

Copy link
Copy Markdown
Contributor

I just published @types/[email protected] to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Other Approved This PR was reviewed and signed-off by a community member. Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants