Skip to content

[@types/react] Enable passing children down to "ExoticComponent"s #33602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raon0211 wants to merge 2 commits into from
Closed

[@types/react] Enable passing children down to "ExoticComponent"s #33602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02e4dd0
Enable passing down children to "ExoticComponent"s
raon0211 Mar 5, 2019
6972bcc
Add test for passing children down to memoed components
raon0211 Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/react/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ declare namespace React {
/**
* **NOTE**: Exotic components are not callable.
*/
(props: P): (ReactElement|null);
(props: PropsWithChildren<P>): ReactElement | null;
readonly $$typeof: symbol;
}

Expand Down
4 changes: 4 additions & 0 deletions types/react/test/tsx.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,10 @@ const Memoized6 = React.memo(props => null);
// $ExpectError
<Memoized6 foo/>;

const BeforeMemoized7: React.FC = ({ children }) => null;
const Memoized7 = React.memo(BeforeMemoized7);
<Memoized7>foo</Memoized7>;

// NOTE: this test _requires_ TypeScript 3.1
// It is passing, for what it's worth.
// const Memoized7 = React.memo((() => {
Expand Down