Skip to content

[types/react] Fix regression with PropsWithChildren [The Travis build is lying] #33462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 3 commits into from
Mar 6, 2019
Merged

[types/react] Fix regression with PropsWithChildren [The Travis build is lying] #33462

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7296f96
Fix regression
VincentLanglet Feb 28, 2019
a1b42a8
Update index.d.ts
VincentLanglet Mar 6, 2019
faf41a5
Update index.d.ts
VincentLanglet Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/react/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ declare namespace React {
// always pass children as variadic arguments to `createElement`.
// In the future, if we can define its call signature conditionally
// on the existence of `children` in `P`, then we should remove this.
readonly props: Readonly<PropsWithChildren<P>>;
readonly props: Readonly<P> & Readonly<{ children?: ReactNode }>;
state: Readonly<S>;
/**
* @deprecated
Expand Down