[types/react] Fix regression with PropsWithChildren [The Travis build is lying]#33462
[types/react] Fix regression with PropsWithChildren [The Travis build is lying]#33462sandersn merged 3 commits intoDefinitelyTyped:masterfrom VincentLanglet:patch-1
Conversation
VincentLanglet
requested review from
Jessidhia and
johnnyreilly
as code owners
typescript-bot
added
Popular package
|
@VincentLanglet Thank you for submitting this PR! 🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @tkrotoff @DovydasNavickas @onigoetz @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @pshrmn @threepointone - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
typescript-bot
added
The Travis CI build failed
and removed
Awaiting reviewer feedback
labels
|
@VincentLanglet The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
ferdaber
left a comment
ferdaber
left a comment
There was a problem hiding this comment.
I did notice this when I was playing around with HOCs but didn't have time to look into it :/
typescript-bot
added
the
Owner Approved
|
@sandersn HI, I have some issue with the time taken by the CI build. |
VincentLanglet
changed the title
|
@gabritto Hi, you're the last one who merge some PR in this repo. |
|
@VincentLanglet I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues. |
|
@VincentLanglet The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
@Jessidhia @johnnyreilly Hi ! The tests are always getting timeout... |
|
Calling @sandersn for manual intervention. @VincentLanglet if you run the tests locally and post the logs here someone can merge it manually without the bot. |
|
@ferdaber is right, except you don't need to post the logs. I'll believe you. :) Edit: the command is |
|
The test passed locally |
|
I just published |
4 participants
There is already two issues talking about issue with the introduction of PropsWithChildren.
#33461
#33416
This type is an helper for a functional component
I don't really understand why the change
Readonly<P & { children?: ReactNode }>instead ofReadonly<P> & Readonly<{ children?: ReactNode }>breaks something but the use of the helper in this case is not necessary so, quicker way to fix the regression is to revert this line.