[react] Replace {} by ReactElement in ReactFragment definition#33346
[react] Replace {} by ReactElement in ReactFragment definition#33346cshaa wants to merge 2 commits intoDefinitelyTyped:masterfrom
Conversation
fixes DefinitelyTyped#29307, possibly a breaking change
|
@m93a Thank you for submitting this PR! 🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @tkrotoff @DovydasNavickas @onigoetz @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @pshrmn @threepointone - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@Jessidhia I forgot, what was the blocker for removing this other than the high amount of breakage this causes? |
|
Oh, it's probably failing because many packages pass functions or custom objects as children. This shouldn't have anything to do with Fragments, however. Maybe adding I'm certain that non-primitive |
|
@m93a The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
I've looked at the errors in Travis. Most of them seem unrelated to the PR 🤔. Could you please help me out with this? |
|
A lot of those are from untouched dependencies that haven't been retested since newer versions of TS, but the recompose ones look interesting, did you take a look at those? |
|
@m93a I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues. |
|
@m93a To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you! |
fixes #29307, possibly a breaking change
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.