chore(graphql-resolve-batch): run prettier#32696
chore(graphql-resolve-batch): run prettier#32696mc0 wants to merge 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@mc0 Thank you for submitting this PR! 🔔 @Nayni - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@mc0 The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
Hey @mc0 , It appears that the typings are failing because of some changes to how ReadOnlyArray type works with the latest version of TypeScript. I know your PR is only a style change, but would you be willing to add a few changes that ensure the tests pass? My plan is to change from ReadOnlyArray to a regular Array. I've already prepared a branch with the changes and checked that tests will pass. Would you be so kind to incorporate my changes into this PR so we can merge them all together? The relevant commit is right here: Thanks! |
|
Saw your Issue: microsoft/dtslint#192 Let's first wait for an answer there. |
|
@mc0 I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues. |
typescript-bot
added
the
Abandoned
|
@mc0 To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you! |
3 participants
npm test.)npm run lint package-name(ortscif notslint.jsonis present).tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.Ran prettier on index.d.ts but also seeing if tests pass with almost no changes.