feat(graphql): add TArgs generic to more graphql types#32694
feat(graphql): add TArgs generic to more graphql types#32694minestarks merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
|
@mc0 Thank you for submitting this PR! 🔔 @TonyPythoneer @calebmer @intellix @firede @kepennar @freiksenet @IvanGoncharov @DxCx @rportugal @tgriesser @dyst5422 @adnsio @divyenduz @bradzacher @clayne11 @JCMais @langpavel - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@mc0 The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
See microsoft/dtslint#192 for why this build is failing and related #32696 for a succinct example of the tests failing for the dependent package. |
|
@mc0 I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues. |
|
🤷♂️ |
|
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
|
I just published |
Was added in DefinitelyTyped/DefinitelyTyped#32694 Motivation for removal graphql#2481
Was added in DefinitelyTyped/DefinitelyTyped#32694 Motivation for removal graphql#2481
Was added in DefinitelyTyped/DefinitelyTyped#32694 Motivation for removal graphql#2481
Was added in DefinitelyTyped/DefinitelyTyped#32694 Motivation for removal #2481
npm test.)npm run lint package-name(ortscif notslint.jsonis present).tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.This builds off of some changes from #22789 and continues having TArgs be optional. This is not a breaking change. It's possible that
unknownis a better option for TArgs; however, that would be TS3 specific and be a breaking change.This change is to allow overriding TArgs in more places. For example, allowing
anyargs or to restrict args further. This primarily impacts theGraphQLFieldConfigMapandGraphQLObjectTypetypes.Using
GraphQLFieldConfigMapwith generics:Using
GraphQLObjectTypewith generics: