Skip to content

Add type definitions for project fluent's constituent packages (fluent, fluent-react and fluent-langneg)#32235

Merged
uniqueiniquity merged 2 commits intoDefinitelyTyped:masterfrom
huy-nguyen:add-fluent-project
Jan 24, 2019
Merged

Add type definitions for project fluent's constituent packages (fluent, fluent-react and fluent-langneg)#32235
uniqueiniquity merged 2 commits intoDefinitelyTyped:masterfrom
huy-nguyen:add-fluent-project

Conversation

@huy-nguyen
Copy link
Copy Markdown
Contributor

@huy-nguyen huy-nguyen commented Jan 17, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Awaiting reviewer feedback labels Jan 17, 2019
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jan 17, 2019

@huy-nguyen Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@huy-nguyen huy-nguyen changed the title Add type definitions for project fluent's constituent packages Add type definitions for project fluent's constituent packages (fluent, fluent-react and fluent-langneg) Jan 17, 2019
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Jan 22, 2019
@typescript-bot
Copy link
Copy Markdown
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Jan 23, 2019
@typescript-bot
Copy link
Copy Markdown
Contributor

@huy-nguyen One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

- Export functions instead of interfaces.

- Remove unnecessary generics.
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @uniqueiniquity - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@uniqueiniquity uniqueiniquity merged commit e321898 into DefinitelyTyped:master Jan 24, 2019
@huy-nguyen huy-nguyen deleted the add-fluent-project branch January 25, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Definition This PR creates a new definition package. Revision needed This PR needs code changes before it can be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants