Skip to content

Conversation

@Jessidhia
Copy link
Member

@Jessidhia Jessidhia commented Dec 3, 2018

It was deleted in facebook/react#14336. Any of the current use cases are provided by useLayoutEffect, it wasn't useful for any potential new use cases because refs are not yet attached when it's called. It might be brought back if they find a way to make it useful.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Dec 3, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 3, 2018

@Kovensky Thank you for submitting this PR!

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @tkrotoff @DovydasNavickas @onigoetz @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@johnnyreilly johnnyreilly merged commit 3c3c8d0 into DefinitelyTyped:master Dec 3, 2018
@johnnyreilly
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants