Skip to content

[react]: remove null union from state which introduced a BC#26946

Merged
johnnyreilly merged 1 commit intoDefinitelyTyped:masterfrom
Hotell:mh/react/revert-state-bc
Jun 29, 2018
Merged

[react]: remove null union from state which introduced a BC#26946
johnnyreilly merged 1 commit intoDefinitelyTyped:masterfrom
Hotell:mh/react/revert-state-bc

Conversation

@Hotell
Copy link
Copy Markdown
Contributor

@Hotell Hotell commented Jun 29, 2018

Please fill in this template.

reverts #26912 #26813

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

@Hotell Hotell requested a review from johnnyreilly as a code owner June 29, 2018 11:31
@Hotell Hotell force-pushed the mh/react/revert-state-bc branch from 522d0dd to 1de3121 Compare June 29, 2018 11:42
@Rycochet Rycochet mentioned this pull request Jun 29, 2018
9 tasks
@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Jun 29, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

@Hotell Thank you for submitting this PR!

🔔 @jgoz @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @morcerf @tkrotoff @DovydasNavickas @onigoetz @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@johnnyreilly johnnyreilly merged commit a5b0278 into DefinitelyTyped:master Jun 29, 2018
@johnnyreilly
Copy link
Copy Markdown
Member

Thanks @Hotell !

@johnnyreilly
Copy link
Copy Markdown
Member

For what it's worth I'd like to say that @Hotell was trying to do a good thing with his initial PR. It caused some problems and he responded. Kudos to him for that.

Contributing to OSS is to be applauded. I applaud @Hotell! 👏 🌻 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants