Skip to content

[react]: make Component.render() abstract to prevent runtime errors and get better DX #26545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hotell wants to merge 2 commits into from
Closed

[react]: make Component.render() abstract to prevent runtime errors and get better DX #26545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87541e4
feat(react): make render() abstract and provide better DX
Hotell Jun 14, 2018
3ac66ce
fix: update all 3rd party react libs to properly implement new abstra…
Hotell Jun 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
2 changes: 1 addition & 1 deletion types/braft-editor/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,4 @@ declare namespace BraftEditor {
blur?: () => any;
}
}
declare class BraftEditor extends React.Component<BraftEditor.editorProps> { }
declare class BraftEditor extends React.Component<BraftEditor.editorProps> { render(): React.ReactNode }
1 change: 1 addition & 0 deletions types/emoji-mart/dist-es/components/picker.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,6 @@ export interface Props {
}

export default class Picker extends React.PureComponent<Props> {
render(): React.ReactNode
// everything inside it is supposed to be private
}
2 changes: 1 addition & 1 deletion types/fluxible-router/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import * as React from 'react';
import { FluxibleContext } from 'fluxible';
import BaseStore = require('fluxible/addons/BaseStore');

export class NavLink extends React.Component<NavLinkProps, any> { }
export class NavLink extends React.Component<NavLinkProps, any> { render(): React.ReactNode }

export class RouteStore extends BaseStore {
static withStaticRoutes(routes: object): typeof RouteStore;
Expand Down
2 changes: 1 addition & 1 deletion types/material-ui-datatables/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,4 @@ export interface DataTableProps {
onRowSelection: (selectedRows: any) => void;
}

export default class DataTable extends React.Component<Partial<DataTableProps>> { }
export default class DataTable extends React.Component<Partial<DataTableProps>> { render(): React.ReactNode }
42 changes: 21 additions & 21 deletions types/material-ui/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,15 +824,15 @@ declare namespace __MaterialUI {
style?: React.CSSProperties;
}

export class BottomNavigation extends React.Component<BottomNavigationProps> { }
export class BottomNavigation extends React.Component<BottomNavigationProps> { render(): React.ReactNode }

export interface BottomNavigationItemProps extends SharedEnhancedButtonProps<BottomNavigationItem> {
className?: string;
icon?: React.ReactNode;
label?: React.ReactNode;
}

export class BottomNavigationItem extends React.Component<BottomNavigationItemProps> { }
export class BottomNavigationItem extends React.Component<BottomNavigationItemProps> { render(): React.ReactNode }
}

namespace Card {
Expand Down Expand Up @@ -8896,14 +8896,14 @@ declare module 'material-ui/svg-icons' {

declare module 'material-ui/internal/AppCanvas' {
export interface AppCanvasProps extends React.Props<AppCanvas> { }
class AppCanvas extends React.Component<AppCanvasProps> { }
class AppCanvas extends React.Component<AppCanvasProps> { render(): React.ReactNode }
export default AppCanvas;
}
declare module 'material-ui/internal/AutoLockScrolling' {
export interface AutoLockScrollingProps extends React.Props<AutoLockScrolling> {
lock: boolean;
}
class AutoLockScrolling extends React.Component<AutoLockScrollingProps> { }
class AutoLockScrolling extends React.Component<AutoLockScrollingProps> { render(): React.ReactNode }
export default AutoLockScrolling;
}
declare module 'material-ui/internal/BeforeAfterWrapper' {
Expand All @@ -8915,7 +8915,7 @@ declare module 'material-ui/internal/BeforeAfterWrapper' {
elementType?: string;
style?: React.CSSProperties;
}
class BeforeAfterWrapper extends React.Component<BeforeAfterWrapperProps> { }
class BeforeAfterWrapper extends React.Component<BeforeAfterWrapperProps> { render(): React.ReactNode }
export default BeforeAfterWrapper;
}
declare module 'material-ui/internal/CircleRipple' {
Expand All @@ -8925,33 +8925,33 @@ declare module 'material-ui/internal/CircleRipple' {
opacity?: number;
style?: React.CSSProperties;
}
class CircleRipple extends React.Component<CircleRippleProps> { }
class CircleRipple extends React.Component<CircleRippleProps> { render(): React.ReactNode }
export default CircleRipple;
}
declare module 'material-ui/internal/ClearFix' {
export interface ClearFixProps extends React.Props<ClearFix> {
style?: React.CSSProperties;
}
class ClearFix extends React.Component<ClearFixProps> { }
class ClearFix extends React.Component<ClearFixProps> { render(): React.ReactNode }
export default ClearFix;
}
declare module 'material-ui/internal/ClickAwayListener' {
export interface ClickAwayListenerProps extends React.Props<ClickAwayListener> {
onClickAway?: any;
}
class ClickAwayListener extends React.Component<ClickAwayListenerProps> { }
class ClickAwayListener extends React.Component<ClickAwayListenerProps> { render(): React.ReactNode }
export default ClickAwayListener;
}
declare module 'material-ui/internal/EnhancedButton' {
export interface EnhancedButtonProps extends __MaterialUI.SharedEnhancedButtonProps<EnhancedButton> {
}
class EnhancedButton extends React.Component<EnhancedButtonProps> { }
class EnhancedButton extends React.Component<EnhancedButtonProps> { render(): React.ReactNode }
export default EnhancedButton;
}
declare module 'material-ui/internal/EnhancedSwitch' {
export interface EnhancedSwitchProps extends __MaterialUI.Switches.CommonEnhancedSwitchProps<EnhancedSwitch> {
}
class EnhancedSwitch extends React.Component<EnhancedSwitchProps> { }
class EnhancedSwitch extends React.Component<EnhancedSwitchProps> { render(): React.ReactNode }
export default EnhancedSwitch;
}
declare module 'material-ui/internal/ExpandTransition' {
Expand All @@ -8963,7 +8963,7 @@ declare module 'material-ui/internal/ExpandTransition' {
transitionDelay?: number;
transitionDuration?: number;
}
class ExpandTransition extends React.Component<ExpandTransitionProps> { }
class ExpandTransition extends React.Component<ExpandTransitionProps> { render(): React.ReactNode }
export default ExpandTransition;
}
declare module 'material-ui/internal/ExpandTransitionChild' {
Expand All @@ -8973,7 +8973,7 @@ declare module 'material-ui/internal/ExpandTransitionChild' {
transitionDelay?: number;
transitionDuration?: number;
}
class ExpandTransitionChild extends React.Component<ExpandTransitionChildProps> { }
class ExpandTransitionChild extends React.Component<ExpandTransitionChildProps> { render(): React.ReactNode }
export default ExpandTransitionChild;
}
declare module 'material-ui/internal/FocusRipple' {
Expand All @@ -8984,7 +8984,7 @@ declare module 'material-ui/internal/FocusRipple' {
show?: boolean;
style?: React.CSSProperties;
}
class FocusRipple extends React.Component<FocusRippleProps> { }
class FocusRipple extends React.Component<FocusRippleProps> { render(): React.ReactNode }
export default FocusRipple;
}
declare module 'material-ui/internal/Overlay' {
Expand All @@ -8995,7 +8995,7 @@ declare module 'material-ui/internal/Overlay' {
transitionEnabled?: boolean;
onClick?: React.MouseEventHandler<{}>;
}
class Overlay extends React.Component<OverlayProps> { }
class Overlay extends React.Component<OverlayProps> { render(): React.ReactNode }
export default Overlay;
}
declare module 'material-ui/internal/RenderToLayer' {
Expand All @@ -9005,7 +9005,7 @@ declare module 'material-ui/internal/RenderToLayer' {
render: Function;
useLayerForClickAway?: boolean;
}
class RenderToLayer extends React.Component<RenderToLayerProps> { }
class RenderToLayer extends React.Component<RenderToLayerProps> { render(): React.ReactNode }
export default RenderToLayer;
}
declare module 'material-ui/internal/ScaleIn' {
Expand All @@ -9015,7 +9015,7 @@ declare module 'material-ui/internal/ScaleIn' {
maxScale?: number;
minScale?: number;
}
class ScaleIn extends React.Component<ScaleInProps> { }
class ScaleIn extends React.Component<ScaleInProps> { render(): React.ReactNode }
export default ScaleIn;
}
declare module 'material-ui/internal/ScaleInChild' {
Expand All @@ -9025,7 +9025,7 @@ declare module 'material-ui/internal/ScaleInChild' {
minScale?: number;
style?: React.CSSProperties;
}
class ScaleInChild extends React.Component<ScaleInChildProps> { }
class ScaleInChild extends React.Component<ScaleInChildProps> { render(): React.ReactNode }
export default ScaleInChild;
}
declare module 'material-ui/internal/SlideIn' {
Expand All @@ -9035,7 +9035,7 @@ declare module 'material-ui/internal/SlideIn' {
enterDelay?: number;
style?: React.CSSProperties;
}
class SlideIn extends React.Component<SlideInProps> { }
class SlideIn extends React.Component<SlideInProps> { render(): React.ReactNode }
export default SlideIn;
}
declare module 'material-ui/internal/SlideInChild' {
Expand All @@ -9045,7 +9045,7 @@ declare module 'material-ui/internal/SlideInChild' {
getLeaveDirection: Function;
style?: React.CSSProperties;
}
class SlideInChild extends React.Component<SlideInChildProps> { }
class SlideInChild extends React.Component<SlideInChildProps> { render(): React.ReactNode }
export default SlideInChild;
}
declare module 'material-ui/internal/Tooltip' {
Expand All @@ -9058,7 +9058,7 @@ declare module 'material-ui/internal/Tooltip' {
touch?: boolean;
verticalPosition?: __MaterialUI.propTypes.vertical;
}
class Tooltip extends React.Component<TooltipProps> { }
class Tooltip extends React.Component<TooltipProps> { render(): React.ReactNode }
export default Tooltip;
}
declare module 'material-ui/internal/TouchRipple' {
Expand All @@ -9069,6 +9069,6 @@ declare module 'material-ui/internal/TouchRipple' {
opacity?: number;
style?: React.CSSProperties;
}
class TouchRipple extends React.Component<TouchRippleProps> { }
class TouchRipple extends React.Component<TouchRippleProps> { render(): React.ReactNode }
export default TouchRipple;
}
12 changes: 6 additions & 6 deletions types/mirrorx/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,11 @@ export const actions: Actions;
export function hook(): (subscriber: () => any) => any;
export function defaults(): (options: defaultOptions) => void;
export const render: Renderer;
export class Router<State> extends React.Component<ConnectedRouterProps<State>> { }
export class Link extends React.Component<LinkProps, any> { }
export class NavLink extends React.Component<NavLinkProps, any> { }
export class Redirect extends React.Component<RedirectProps, any> { }
export class Route<T extends RouteProps = RouteProps> extends React.Component<T, any> { }
export class Prompt extends React.Component<PromptProps, any> { }
export class Router<State> extends React.Component<ConnectedRouterProps<State>> { render(): React.ReactNode }
export class Link extends React.Component<LinkProps, any> { render(): React.ReactNode }
export class NavLink extends React.Component<NavLinkProps, any> { render(): React.ReactNode }
export class Redirect extends React.Component<RedirectProps, any> { render(): React.ReactNode }
export class Route<T extends RouteProps = RouteProps> extends React.Component<T, any> { render(): React.ReactNode }
export class Prompt extends React.Component<PromptProps, any> { render(): React.ReactNode }
export function withRouter<P extends RouteComponentProps<any>>(component: React.ComponentType<P>): React.ComponentClass<Omit<P, keyof RouteComponentProps<any>>>;
export function withRouter<TFunction extends React.ComponentClass<any>>(target: TFunction): TFunction;
Loading