Remove URL and URLSearchParams from nodeJS global#25356
Conversation
|
@rbuckton Thank you for submitting this PR! 🔔 @parambirs @tellnes @WilcoBakker @octo-sniffle @smac89 @Flarna @mwiktorczyk @wwwy3y3 @DeividasBakanas @kjin @alvis @OliverJAsh @eps1lon @Hannes-Magnusson-CK @jkomyno @ajafff @hoo29 @n-e - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@rbuckton The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
@Andy-MS, the push build seems to be failing in runWithListeningChildProcess again: |
41098d9 to
60bb4ed
Compare
|
@rbuckton The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
waiting patiently on this one
|
|
after updating
i get the following installed
i then try to compile my server and it still wont build how are we to resolve these wide spread build errors RxJS on the client side still fails to build with import problems RxJS 6 |
|
@nhhockeyplayer try |
|
Okay. But now I cannot use the global I have to import it from Can we anyhow make |
This reverts the change that adds URL and URLSearchParams to the global scope in NodeJS due to a collision with DOM types when both are used..
Fixes #25342.